You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/24 19:37:06 UTC
[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5781
to review the following change.
Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN
......................................................................
Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN
Change-Id: Ida3f92ee9651d4540c886a5e7846bff0eedbb226
---
M src/kudu/gutil/macros.h
1 file changed, 1 insertion(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/5781/1
--
To view, visit http://gerrit.cloudera.org:8080/5781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida3f92ee9651d4540c886a5e7846bff0eedbb226
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida3f92ee9651d4540c886a5e7846bff0eedbb226
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Use C++11 constructor deletion for DISALLOW COPY AND ASSIGN
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN
......................................................................
Use C++11 constructor deletion for DISALLOW_COPY_AND_ASSIGN
Change-Id: Ida3f92ee9651d4540c886a5e7846bff0eedbb226
Reviewed-on: http://gerrit.cloudera.org:8080/5781
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/macros.h
1 file changed, 1 insertion(+), 12 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida3f92ee9651d4540c886a5e7846bff0eedbb226
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>