You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2019/04/18 19:41:23 UTC
[Bug 63363] New: Add proguard rules
https://bz.apache.org/bugzilla/show_bug.cgi?id=63363
Bug ID: 63363
Summary: Add proguard rules
Product: POI
Version: unspecified
Hardware: PC
OS: other
Status: NEW
Severity: normal
Priority: P2
Component: POI Overall
Assignee: dev@poi.apache.org
Reporter: gojunkmailx@gmail.com
Target Milestone: ---
Here is an example set of rules that could be added:
https://github.com/square/okhttp/blob/3256f0bddcd58cafbf06cb4ea4bbfe9bdaca2abb/okhttp/src/main/resources/META-INF/proguard/okhttp3.pro
Since there's so much reflection, it would be nice if a full set of rules could
be developed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63363] Add proguard rules
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63363
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
I don't know how proguard-rules would apply to Apache POI, why do you think
these would be of use here?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63363] Add proguard rules
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63363
--- Comment #3 from Andreas Beeker <ki...@apache.org> ---
In the context of reflections, I don't understand why code shrinking would give
us any benefit.
If a user wants to hide the fact, that they are using POI, they can obfuscate
their project including POIs source. But for the sake of debugging, I wouldn't
release optimized code.
Furthermore I assume, that we have performance/memory problems because of
holding a lot of XML based document data ... optimizing only the calls to the
XmlBeans API won't make much of a difference.
So if we would use it in a temporary step, how would it help us with fixing
reflection based problems?
As you seem to be familiar with proguard, how did it help you, to find bugs in
your project or POI itself?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63363] Add proguard rules
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63363
--- Comment #4 from gojunkmailx@gmail.com <go...@gmail.com> ---
Ah, sorry for the misunderstanding. I'm not asking for POI to be proguarded
before it's released (that's gross). Instead, I'm asking that a set of proguard
rules for library consumers be maintained. That is, I shouldn't have to guess
at what rules I need if I want to minify my product before release. Does that
make sense?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 63363] Add proguard rules
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63363
gojunkmailx@gmail.com <go...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #2 from gojunkmailx@gmail.com <go...@gmail.com> ---
POI uses reflection everywhere. The team should try running POI with a code
shrinker and add rules to keep classes accessed via reflection.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org