You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/28 01:29:50 UTC
[GitHub] [beam] apilloud commented on a change in pull request #15820: [BEAM-13099] Use RelMetadataQuery subclass rather than calling RelNode.metadata
apilloud commented on a change in pull request #15820:
URL: https://github.com/apache/beam/pull/15820#discussion_r737953526
##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRelMetadataQuery.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.impl.planner;
+
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.RelNode;
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.metadata.JaninoRelMetadataProvider;
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.metadata.RelMetadataQuery;
+
+public class BeamRelMetadataQuery extends RelMetadataQuery {
+ private NodeStatsMetadata.Handler nodeStatsMetadataHandler;
+
+ private BeamRelMetadataQuery() {
+ super();
Review comment:
nit: this is implicitly added by the compiler and can be dropped. https://docs.oracle.com/javase/tutorial/java/IandI/super.html#:~:text=Note%3A%C2%A0If%20a,is%20no%20problem.
##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRelMetadataQuery.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.impl.planner;
+
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.RelNode;
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.metadata.JaninoRelMetadataProvider;
+import org.apache.beam.vendor.calcite.v1_26_0.org.apache.calcite.rel.metadata.RelMetadataQuery;
+
+public class BeamRelMetadataQuery extends RelMetadataQuery {
+ private NodeStatsMetadata.Handler nodeStatsMetadataHandler;
+
+ private BeamRelMetadataQuery() {
+ super();
+ nodeStatsMetadataHandler = initialHandler(NodeStatsMetadata.Handler.class);
+ }
+
+ public static BeamRelMetadataQuery instance() {
+ return new BeamRelMetadataQuery();
+ }
+
+ public NodeStats getNodeStats(RelNode relNode) {
+ for (; ; ) {
Review comment:
It looks like this was copied from calcite, so we should keep it as is.
bikeshedding nit: There are 4 instances of this and 202 of `while (true)` in Beam. I don't like either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org