You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/02 20:00:38 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4251: Fixed CiaB build issue

ocket8888 opened a new pull request #4251: Fixed CiaB build issue
URL: https://github.com/apache/trafficcontrol/pull/4251
 
 
   ## What does this PR (Pull Request) do?
   - [x] This PR fixes #4246 
   
   Instead of download the Maxmind database, this PR changes the TO Perl build for CiaB to use the database that's bundled into the Traffic Router test package.
   
   ## Which Traffic Control components are affected by this PR?
   - CDN in a Box
   
   ## What is the best way to verify this PR?
   Build CDN-in-a-Box, notice no errors and that TR works
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   - [x] Tests are unnecessary
   - [x] Documentation is unnecessary
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4251: Fixed CiaB build issue

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #4251: Fixed CiaB build issue
URL: https://github.com/apache/trafficcontrol/pull/4251#discussion_r362653335
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/traffic_ops/trafficops-init.sh
 ##########
 @@ -102,7 +102,7 @@ load_data_from() {
 load_data_from /traffic_ops_data
 
 # Copy the free MaxMind GeoLite DB to TrafficOps public directory
-tar -C /var/tmp -zxpvf /GeoLite2-City.tar.gz
-geo_dir=$(find /var/tmp -maxdepth 1 -type d -name GeoLite2-City\*)
-gzip -c "$geo_dir/GeoLite2-City.mmdb" > "$TO_DIR/public/GeoLite2-City.mmdb.gz"
-chown trafops:trafops "$TO_DIR/public/GeoLite2-City.mmdb.gz"
+# tar -C /var/tmp -zxpvf /GeoLite2-City.tar.gz
 
 Review comment:
   yes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 merged pull request #4251: Fixed CiaB build issue

Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4251: Fixed CiaB build issue
URL: https://github.com/apache/trafficcontrol/pull/4251
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mhoppa commented on a change in pull request #4251: Fixed CiaB build issue

Posted by GitBox <gi...@apache.org>.
mhoppa commented on a change in pull request #4251: Fixed CiaB build issue
URL: https://github.com/apache/trafficcontrol/pull/4251#discussion_r362645396
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/traffic_ops/trafficops-init.sh
 ##########
 @@ -102,7 +102,7 @@ load_data_from() {
 load_data_from /traffic_ops_data
 
 # Copy the free MaxMind GeoLite DB to TrafficOps public directory
-tar -C /var/tmp -zxpvf /GeoLite2-City.tar.gz
-geo_dir=$(find /var/tmp -maxdepth 1 -type d -name GeoLite2-City\*)
-gzip -c "$geo_dir/GeoLite2-City.mmdb" > "$TO_DIR/public/GeoLite2-City.mmdb.gz"
-chown trafops:trafops "$TO_DIR/public/GeoLite2-City.mmdb.gz"
+# tar -C /var/tmp -zxpvf /GeoLite2-City.tar.gz
 
 Review comment:
   should we just remove this code instead of commenting out? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services