You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 01:10:32 UTC
[I] [BUG] ApiServiceImpl removeRegister/register are dead code; delete() leaves orphan selector/rule/metadata [shenyu]
Aias00 opened a new issue, #6716:
URL: https://github.com/apache/shenyu/issues/6716
- severity: Medium
- files: `shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ApiServiceImpl.java:159-216,220-233`
- description: `removeRegister(ApiDO)` (159-189) and `register(ApiDO)` (191-216) are private methods that are never invoked anywhere. `delete(...)` (220-233) removes rows from `api` and `tag_relation` only; it never calls `removeRegister`, so the associated `selector`, `rule`, and `metadata` rows are not cleaned up. Likewise `create(...)` does not call `register()`.
- impact: Deleting an API leaves orphaned gateway selector/rule/metadata that the runtime may still route on; creating an API does not auto-publish the corresponding selector/rule/metadata as the (now dead) `register()` method intended.
- suggested_fix: Either invoke `removeRegister` from within `delete(...)` and `register()` from `create(...)`, or delete the dead methods.
- confidence: Medium
- related_existing: none.
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] ApiServiceImpl removeRegister/register are dead code; delete() leaves orphan selector/rule/metadata [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6716:
URL: https://github.com/apache/shenyu/issues/6716#issuecomment-5161306879
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] ApiServiceImpl removeRegister/register are dead code; delete() leaves orphan selector/rule/metadata
- **Link**: https://github.com/apache/shenyu/issues/6716
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] ApiServiceImpl removeRegister/register are dead code; delete() leaves orphan selector/rule/metadata [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6716: [BUG] ApiServiceImpl removeRegister/register are dead code; delete() leaves orphan selector/rule/metadata
URL: https://github.com/apache/shenyu/issues/6716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org