You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by danny0405 <gi...@git.apache.org> on 2015/09/16 10:17:20 UTC
[GitHub] storm pull request: fix same name topologies bug
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/739
fix same name topologies bug
When a topology is submitted repeatedly very closely, or nimbus is too busy to response the repeated submit RPC calls from same topology, there is very high probability that nimbus receive the repeatedly calls of the same topology, and finally several topologies with same name will be running on storm cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danny0405/storm cyz-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/739.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #739
----
commit a99fae0fa0aeb8922ce6cb36962b03bc79210730
Author: chenyuzhao <ch...@meituan.com>
Date: 2015-09-16T08:05:02Z
fix same name topologies bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1050:Topologies with same name run on on...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/739#issuecomment-141256380
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1050:Topologies with same name run on on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1050:Topologies with same name run on on...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the pull request:
https://github.com/apache/storm/pull/739#issuecomment-140941136
I have filed a JIRA issue, thanks for your nice response.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: fix same name topologies bug
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/739#issuecomment-140905717
PR's changeset is small (just one line), but since it's a bug I'd like to leave JIRA issue to let us track easier.
Could you file a JIRA issue so that we can track?
Also please change PR's title to start with JIRA-ISSUE-NUMBER.
Please refer https://github.com/apache/storm/blob/master/DEVELOPER.md#contribute-code to how and where to make JIRA issue, and refer https://github.com/apache/storm/blob/master/DEVELOPER.md#create-a-pull-request to how to create PR's title.
Thanks in advance!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---