[GitHub] [maven-mvnd] gnodet commented on a change in pull request #580: Daemon reuse ignores differences in `.mvn/jvm.config`, fixes #576

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #580:
URL: https://github.com/apache/maven-mvnd/pull/580#discussion_r782214168



##########
File path: client/src/main/java/org/mvndaemon/mvnd/client/DefaultClient.java
##########
@@ -114,6 +115,12 @@ public static void main(String[] argv) throws Exception {
 
         System.setProperty(Environment.MVND_HOME.getProperty(), parameters.mvndHome().toString());
 
+        // .mvn/jvm.config
+        if (Files.isRegularFile(parameters.jvmConfigPath())) {
+            String jvmArgs = Files.lines(parameters.jvmConfigPath()).collect(Collectors.joining(" "));
+            parameters = parameters.withJvmArgs(" " + jvmArgs);

Review comment:
       You can also use `mvnd.maxHeapSize`...
   OpenJDK does accept multiple arguments for `-Xmx` and the first one takes precedence (iirc).  We could check the options that we do support explicitely, but we can't validate all JVM options...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org