You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by lk...@apache.org on 2020/09/29 02:42:06 UTC

[netbeans] branch master updated: Prevent NPE from JavaToCHyperlinkProvider when no project available.

This is an automated email from the ASF dual-hosted git repository.

lkishalmi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
     new 1c1e1dc  Prevent NPE from JavaToCHyperlinkProvider when no project available.
1c1e1dc is described below

commit 1c1e1dc8a709072ac3c68ef8092b8168a8a77834
Author: Jan Lahoda <jl...@netbeans.org>
AuthorDate: Sun Sep 20 22:27:17 2020 +0200

    Prevent NPE from JavaToCHyperlinkProvider when no project available.
---
 .../modules/java/openjdk/editor/JavaToCHyperlinkProvider.java       | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/editor/JavaToCHyperlinkProvider.java b/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/editor/JavaToCHyperlinkProvider.java
index cde601e..b645367 100644
--- a/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/editor/JavaToCHyperlinkProvider.java
+++ b/java/java.openjdk.project/src/org/netbeans/modules/java/openjdk/editor/JavaToCHyperlinkProvider.java
@@ -60,6 +60,8 @@ import org.openide.util.Exceptions;
 @MimeRegistration(mimeType="text/x-java", position=0, service=HyperlinkProviderExt.class)
 public class JavaToCHyperlinkProvider implements HyperlinkProviderExt {
 
+    private static final SourceGroup[] NO_GROUPS = new SourceGroup[0];
+
     @Override
     public Set<HyperlinkType> getSupportedHyperlinkTypes() {
         return EnumSet.of(HyperlinkType.GO_TO_DECLARATION);
@@ -79,8 +81,8 @@ public class JavaToCHyperlinkProvider implements HyperlinkProviderExt {
     public void performClickAction(Document doc, final int offset, HyperlinkType type) {
         FileObject file = NbEditorUtilities.getFileObject(doc);
         Project prj = file != null ? FileOwnerQuery.getOwner(file) : null;
-        SourceGroup[] nativeGroups = ProjectUtils.getSources(prj).getSourceGroups(SourcesImpl.SOURCES_TYPE_JDK_PROJECT_NATIVE);
-
+        SourceGroup[] nativeGroups = prj != null ? ProjectUtils.getSources(prj).getSourceGroups(SourcesImpl.SOURCES_TYPE_JDK_PROJECT_NATIVE)
+                                                 : NO_GROUPS;
         if (nativeGroups.length == 0) {
             findNext().performClickAction(doc, offset, type);
             return ;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists