You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/03 07:54:41 UTC
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #13941: [fix](JSON) Fail to parse JSONPath (libc++)
BiteTheDDDDt commented on code in PR #13941:
URL: https://github.com/apache/doris/pull/13941#discussion_r1012583346
##########
be/src/util/string_util.h:
##########
@@ -130,14 +130,16 @@ template <class T>
using StringCaseUnorderedMap =
std::unordered_map<std::string, T, StringCaseHasher, StringCaseEqual>;
-inline auto get_json_token(const std::string_view& path_string) {
#ifdef USE_LIBCPP
+inline auto get_json_token(const std::string& path_string) {
Review Comment:
maybe we can use template to automatictly find path_string's type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org