[jira] [Resolved] (HBASE-27093) AsyncNonMetaRegionLocator：put Complete CompletableFuture outside lock block

["Duo Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-27093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-27093.
-------------------------------
    Fix Version/s: 2.5.0
                   3.0.0-alpha-3
                   2.4.13
     Hadoop Flags: Reviewed
       Resolution: Fixed

Pushed to branch-2.4+.

Thanks [~xiaowangzhixiao] for contributing!

> AsyncNonMetaRegionLocator：put Complete CompletableFuture outside lock block
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-27093
>                 URL: https://issues.apache.org/jira/browse/HBASE-27093
>             Project: HBase
>          Issue Type: Improvement
>          Components: asyncclient, Client
>    Affects Versions: 3.0.0-alpha-2, 2.4.12
>         Environment: 2.4.12
>            Reporter: zhiwang
>            Assignee: zhiwang
>            Priority: Major
>              Labels: deadlock
>             Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
>  
> {code:java}
> synchronized (tableCache) {
>   tableCache.pendingRequests.remove(req);
>   // fail the request itself, no matter whether it is a DoNotRetryIOException, as we have
>   // already retried several times
>   CompletableFuture<?> future = tableCache.allRequests.remove(req);
>   if (future != null) {
>     future.completeExceptionally(error);
>   }
>   tableCache.clearCompletedRequests(null);
>   // Remove a complete locate request in a synchronized block, so the table cache must have
>   // quota to send a candidate request.
>   toSend = tableCache.getCandidate();
>   toSend.ifPresent(r -> tableCache.send(r));
> }
> {code}
> Complete or completeExceptionally in a lock block may cause deadlock. We can put this action outside the lock block to avoid deadlock.
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)