You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/08 20:34:39 UTC
[GitHub] [beam] robertwb opened a new pull request #13927: Enable non-merging window test on Dataflow Runner v2.
robertwb opened a new pull request #13927:
URL: https://github.com/apache/beam/pull/13927
R: @kennknowles
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles edited a comment on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles edited a comment on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776435281
To be clear: the behavior is odd. I would like to not have it. But it does date back to before Beam and exists to solve a real problem. Maybe it is odd enough that we can break existing behavior to improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-775452670
> Are these tests run as pre-commit?
It's part of Dataflow VR test.
> Also, how does one run (one of them) manually?
I usually change the validatesRunnerV2 target to include just one test case and if you have write access to apache-beam-testing, you can invoke the test locally by ./gradlew :runners:google-cloud-dataflow-java:validatesRunnerV2 directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776212166
https://github.com/apache/beam/blob/595c25263638b3d5624875e46b69a442cedb09a7/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java#L209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776978062
It does predate that change. But in the event EARLIEST is chosen (as it must be for e.g. SQL joins) the problem still applies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-1030616590
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-1037214406
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-1037214406
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776211211
I am wrong. The test configures timestamp combiner to be earliest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-775449795
Run Java Dataflow V2 ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776909577
"Revert" to a state it was never in :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776211625
The issue is the adjustment of timestamps to allow the watermark to move forward in sliding windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776434762
The behavior is very deliberate to avoid a watermark holdup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776220089
I actually think it's sliding windows that has the wrong behavior here in Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776435281
To be clear: the behavior is odd. I would like to not have it. But it does date back to before Beam.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776203367
Pretty-printed output:
```
Expected: iterable with items [
"a:1:1:[1969-12-31T23:59:59.995Z..1970-01-01T00:00:00.005Z)",
"a:2:5:[1970-01-01T00:00:00.000Z..1970-01-01T00:00:00.010Z)",
"a:1:10:[1970-01-01T00:00:00.005Z..1970-01-01T00:00:00.015Z)",
"b:1:8:[1970-01-01T00:00:00.000Z..1970-01-01T00:00:00.010Z)",
"b:1:10:[1970-01-01T00:00:00.005Z..1970-01-01T00:00:00.015Z)"
] in any order
but: not matched: "a:2:1:[1970-01-01T00:00:00.000Z..1970-01-01T00:00:00.010Z)"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776971570
The default timestamp is now end-of-window. (I wonder if this predates that change...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776910104
We still need a solution for the underlying problem: sliding windows and friends are pretty nonfunctional without this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776206304
Parsing:
- value `"a"`
- multiplicity 2
- timestamp 1
- window `[0, 10)`
That timestamp is wrong. It implies a timestamp combiner of MIN (or just a major bug). The default should be END_OF_WINDOW.
I believe the submitted job always has an explicit timestamp combiner and does not leave default up to the service. No?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-777054493
Opened dev list discussion for visibility and looking for good options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776894735
This behavior is also @Experimental(Kind.OUTPUT_TIME). It is also inconsistent between Java and Python (both of which claim to support it as `beam:window_fn:sliding_windows:v1`.) I say we revert this behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13927:
URL: https://github.com/apache/beam/pull/13927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13927:
URL: https://github.com/apache/beam/pull/13927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-801623247
After #14268 this should go in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776149630
It seems like the `testNonPartitioningWindowing` failed in the latest run: https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_PR/18/testReport/org.apache.beam.sdk.transforms.windowing/WindowingTest/testNonPartitioningWindowing/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-776068156
Here's a rundown of the command line options: https://stackoverflow.com/questions/22505533/how-to-run-only-one-unit-test-class-using-gradle
This only works if Gradle knows it is a `Test` type task. Some of our configs are complex enough that this somehow gets obscured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #13927: Enable non-merging window test on Dataflow Runner v2.
Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #13927:
URL: https://github.com/apache/beam/pull/13927#issuecomment-775437046
Are these tests run as pre-commit? Also, how does one run (one of them) manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org