You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/15 09:17:56 UTC
[GitHub] [incubator-nuttx-apps] qinwei2004 opened a new pull request, #1419: apps: getpid should return process id not thread id
qinwei2004 opened a new pull request, #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419
## Summary
following the change in the nuttx kernel, implement the right semantics:
1. getpid should return the main thread id
2. gettid should return the current thread id
update apps code
Refer:
https://github.com/apache/incubator-nuttx/issues/2499
https://github.com/apache/incubator-nuttx/pull/2518
Nuttx Kernel PR:
https://github.com/apache/incubator-nuttx/pull/7597
## Impact
any code that use getpid/gettid need to check
## Testing
ostest PASSED at qemu with configure
1. ARM 32bit: ./tools/configure.sh -l sabre-6quad:nsh
2. ARM 64bit: ./tools/configure.sh -l qemu-armv8a:nsh
Signed-off-by: qinwei1 <qi...@xiaomi.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1419: apps: getpid should return process id not thread id
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on PR #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#issuecomment-1317091900
Should we do something about the mixed case identifiers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1419: apps: getpid should return process id not thread id
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#discussion_r1024258423
##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -118,7 +118,7 @@ static FAR struct pdc_context_s *PDC_ctx_new(void)
/* Get our PID */
Review Comment:
```suggestion
/* Get our TID */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1419: apps: getpid should return process id not thread id
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1419: apps: getpid should return process id not thread id
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#discussion_r1023211077
##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -179,7 +179,7 @@ FAR struct pdc_context_s * PDC_ctx(void)
/* Get our PID */
Review Comment:
```suggestion
/* Get our TID */
```
##########
netutils/thttpd/libhttpd.c:
##########
@@ -2137,7 +2137,7 @@ FAR httpd_server *httpd_initialize(FAR httpd_sockaddr *sa)
/* Save the PID of the main thread */
Review Comment:
```suggestion
/* Save the TID of the main thread */
```
##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -264,7 +264,7 @@ void PDC_ctx_free(void)
/* Get a unique hash key from the PID */
Review Comment:
```suggestion
/* Get a unique hash key from the TID */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] qinwei2004 commented on a diff in pull request #1419: apps: getpid should return process id not thread id
Posted by GitBox <gi...@apache.org>.
qinwei2004 commented on code in PR #1419:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1419#discussion_r1023425010
##########
graphics/pdcurs34/nuttx/pdcthread.c:
##########
@@ -264,7 +264,7 @@ void PDC_ctx_free(void)
/* Get a unique hash key from the PID */
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org