[GitHub] [rocketmq] zongtanghu commented on a change in pull request #1175: [ISSUE #1147]Add name server domain host support

[GitBox <gi...@apache.org>]

zongtanghu commented on a change in pull request #1175: [ISSUE #1147]Add name server domain host support
URL: https://github.com/apache/rocketmq/pull/1175#discussion_r277650849
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java
 ##########
 @@ -241,6 +247,15 @@ public void setLanguage(LanguageCode language) {
     }
 
     public String getNamespace() {
+        if (StringUtils.isNotEmpty(namespace)) {
+            return namespace;
+        }
+
+        if (StringUtils.isNotEmpty(this.namesrvAddr)) {
 
 Review comment:
   Here,do you mean that if namespace is empty,then return the value by parseInstanceIdFromEndpoint() method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services