You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Xuefu Zhang (JIRA)" <ji...@apache.org> on 2011/03/23 18:36:05 UTC
[jira] [Created] (PIG-1933) Hints such as 'collected' and 'skewed'
for "group by" or "join by" should not be treated as tokens.
Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
---------------------------------------------------------------------------------------------------
Key: PIG-1933
URL: https://issues.apache.org/jira/browse/PIG-1933
Project: Pig
Issue Type: Bug
Affects Versions: 0.9.0
Reporter: Xuefu Zhang
Assignee: Xuefu Zhang
Fix For: 0.9.0
The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
A = load 'skewed';
This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1933) Hints such as 'collected' and
'skewed' for "group by" or "join by" should not be treated as tokens.
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010444#comment-13010444 ]
Xuefu Zhang commented on PIG-1933:
----------------------------------
test-patch run result:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
> ---------------------------------------------------------------------------------------------------
>
> Key: PIG-1933
> URL: https://issues.apache.org/jira/browse/PIG-1933
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1933.patch
>
>
> The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
> A = load 'skewed';
> This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-1933) Hints such as 'collected' and 'skewed'
for "group by" or "join by" should not be treated as tokens.
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thejas M Nair resolved PIG-1933.
--------------------------------
Resolution: Fixed
> Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
> ---------------------------------------------------------------------------------------------------
>
> Key: PIG-1933
> URL: https://issues.apache.org/jira/browse/PIG-1933
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1933.patch
>
>
> The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
> A = load 'skewed';
> This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1933) Hints such as 'collected' and
'skewed' for "group by" or "join by" should not be treated as tokens.
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010467#comment-13010467 ]
Thejas M Nair commented on PIG-1933:
------------------------------------
Patch committed to trunk.
> Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
> ---------------------------------------------------------------------------------------------------
>
> Key: PIG-1933
> URL: https://issues.apache.org/jira/browse/PIG-1933
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1933.patch
>
>
> The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
> A = load 'skewed';
> This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1933) Hints such as 'collected' and
'skewed' for "group by" or "join by" should not be treated as tokens.
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010446#comment-13010446 ]
Thejas M Nair commented on PIG-1933:
------------------------------------
+1
> Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
> ---------------------------------------------------------------------------------------------------
>
> Key: PIG-1933
> URL: https://issues.apache.org/jira/browse/PIG-1933
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1933.patch
>
>
> The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
> A = load 'skewed';
> This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1933) Hints such as 'collected' and 'skewed'
for "group by" or "join by" should not be treated as tokens.
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1933:
-----------------------------
Attachment: PIG-1933.patch
Unit tests passed. Test-patch run is in progress.
> Hints such as 'collected' and 'skewed' for "group by" or "join by" should not be treated as tokens.
> ---------------------------------------------------------------------------------------------------
>
> Key: PIG-1933
> URL: https://issues.apache.org/jira/browse/PIG-1933
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1933.patch
>
>
> The current parser implementation takes hints used for group by or join by such as 'collected' and 'skewed' as tokens, which is different from the old parser, causing some undesirable side-effects. For instance, the following query will fail.
> A = load 'skewed';
> This needs to be corrected to be consistent with the old parser.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira