[jira] [Commented] (PHOENIX-4373) Local index variable length key can have trailing nulls while upserting

["Vincent Poon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250623#comment-16250623 ] 

Vincent Poon commented on PHOENIX-4373:
---------------------------------------

[~jamestaylor] Can you review this patch?  Thanks!

> Local index variable length key can have trailing nulls while upserting
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-4373
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4373
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>         Attachments: PHOENIX-4373.v1.master.patch
>
>
> In the UpsertCompiler#setValues() , if it's a local index, the key is prefixed with regionPrefix.  During that process, ptr.get() is called to get the base key, and the code assumes the entire array should be used.  However, if it's a variable length key, we could have trailing nulls since the base key ptr array size is just an estimate. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)