[GitHub] [flink] wangyang0918 commented on a change in pull request #11630: [FLINK-16921][e2e] Describe all resources and show pods logs before cleanup when failed

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #11630: [FLINK-16921][e2e] Describe all resources and show pods logs before cleanup when failed
URL: https://github.com/apache/flink/pull/11630#discussion_r403462746
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
 ##########
 @@ -49,7 +54,4 @@ kubectl wait --for=condition=complete job/flink-job-cluster --timeout=1h
 kubectl cp `kubectl get pods | awk '/task-manager/ {print $1}'`:/cache/${OUTPUT_FILE} ${OUTPUT_VOLUME}/${OUTPUT_FILE}
 
 check_result_hash "WordCount" ${OUTPUT_VOLUME}/${OUTPUT_FILE} "${RESULT_HASH}"
-
-if [ $? != 0 ];then
-  debug_copy_and_show_logs
-fi
+SUCCEEDED=$?
 
 Review comment:
   We have already use the `on_exit cleanup` in `common_kubernetes.sh`. So i put the `debug_and_show_logs` in `cleanup`, it will always be called before the script exits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services