You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/01/27 09:34:31 UTC

[GitHub] [hbase] YutSean commented on a change in pull request #4072: HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down

YutSean commented on a change in pull request #4072:
URL: https://github.com/apache/hbase/pull/4072#discussion_r793417453



##########
File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java
##########
@@ -131,18 +131,6 @@ public void testCurrentOnEmptyCell() throws IOException {
     assertNull(r.current());
   }
 
-  @Test
-  public void testAdvanceTwiceOnEmptyCell() throws IOException {

Review comment:
       > Better keep this test but use two assertFalse to confirm that the second advance call will return false?
   
   After the change, empty list will always return false. I think we could change the UT's name to testAdvanceMultipieOnEmptyCell and use an arbitrary value > 2 to assert false. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org