You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2019/01/05 22:37:16 UTC
[spark] branch master updated: [SPARK-26545] Fix typo in
EqualNullSafe's truth table comment
This is an automated email from the ASF dual-hosted git repository.
lixiao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 4ab5b5b [SPARK-26545] Fix typo in EqualNullSafe's truth table comment
4ab5b5b is described below
commit 4ab5b5b9185f60f671d90d94732d0d784afa5f84
Author: Kris Mok <kr...@databricks.com>
AuthorDate: Sat Jan 5 14:37:04 2019 -0800
[SPARK-26545] Fix typo in EqualNullSafe's truth table comment
## What changes were proposed in this pull request?
The truth table comment in EqualNullSafe incorrectly marked FALSE results as UNKNOWN.
## How was this patch tested?
N/A
Closes #23461 from rednaxelafx/fix-typo.
Authored-by: Kris Mok <kr...@databricks.com>
Signed-off-by: gatorsmile <ga...@gmail.com>
---
.../org/apache/spark/sql/catalyst/expressions/predicates.scala | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
index 01ecb99..37fe22f 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
@@ -653,9 +653,9 @@ case class EqualNullSafe(left: Expression, right: Expression) extends BinaryComp
// +---------+---------+---------+---------+
// | <=> | TRUE | FALSE | UNKNOWN |
// +---------+---------+---------+---------+
- // | TRUE | TRUE | FALSE | UNKNOWN |
- // | FALSE | FALSE | TRUE | UNKNOWN |
- // | UNKNOWN | UNKNOWN | UNKNOWN | TRUE |
+ // | TRUE | TRUE | FALSE | FALSE |
+ // | FALSE | FALSE | TRUE | FALSE |
+ // | UNKNOWN | FALSE | FALSE | TRUE |
// +---------+---------+---------+---------+
override def eval(input: InternalRow): Any = {
val input1 = left.eval(input)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org