You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/23 22:08:10 UTC

[GitHub] [couchdb] kocolosk commented on a change in pull request #3526: Adopt structured logging via new Erlang 21 logger

kocolosk commented on a change in pull request #3526:
URL: https://github.com/apache/couchdb/pull/3526#discussion_r619518841



##########
File path: src/chttpd/src/chttpd.erl
##########
@@ -16,6 +16,7 @@
 
 -include_lib("couch/include/couch_db.hrl").
 -include_lib("chttpd/include/chttpd.hrl").
+-include_lib("kernel/include/logger.hrl").

Review comment:
       Ah, I had gone back and forth on whether to include it in the header file(s) and just forgot to remove it. This is one topic I wanted to get feedback on. I ended up adding logger.hrl explicitly everywhere, but would it be better to embed in other headers? I don't have a strong preference.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org