You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/16 01:18:28 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

masayuki2009 opened a new pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253


   ## Summary
   
   - In the previous implementation, cxd56_stop() checked the internal
   state before sending AUDIO_MSG_STOP to the message queue. However,
   if the worker thread took time to turn on AMP, cxd560_stop() was
   not able to send the message and caused a deadlock.
   
   - This commit fixes this issue by always sending AUDIO_MSG_STOP
   regardless of the internal state.
   
   ## Impact
   
   - This PR affects cxd56.c audio driver.
   
   ## Testing
   
   - I tested this PR with nxrecorder and nxplayer with spresense.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea merged pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253#issuecomment-644483109


   @btashton 
   
   Hmm, all Build / macOS were canceled...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253#issuecomment-644520138


   > @btashton
   > 
   > Hmm, all Build / macOS were canceled...
   
   I've updated the commit date and pushed with -f to kick the CI again.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253#issuecomment-644520715


   @masayuki2009 you can also wait for the runs to finish or cancel them and then click the re-run all button. Not ideal but that's all I got :/ the macOS runners just seem to be less reliable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1253: drivers: audio: Fix cxd56_stop in cxd56.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1253:
URL: https://github.com/apache/incubator-nuttx/pull/1253#issuecomment-644474148


   Hi @jerpelea @tobias2johansson,
   
   This is another fix that I found during testing nxrecorder.
   Could you please review this PR?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org