You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/12/21 12:40:49 UTC

svn commit: r1896238 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java

Author: tilman
Date: Tue Dec 21 12:40:49 2021
New Revision: 1896238

URL: http://svn.apache.org/viewvc?rev=1896238&view=rev
Log:
PDFBOX-4892: avoid memory leaks

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java?rev=1896238&r1=1896237&r2=1896238&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/fdf/FDFDocument.java Tue Dec 21 12:40:49 2021
@@ -250,7 +250,9 @@ public class FDFDocument implements Clos
      */
     public void save(File fileName) throws IOException
     {
-        save(new FileOutputStream(fileName));
+        FileOutputStream fos = new FileOutputStream(fileName);
+        save(fos);
+        fos.close();
     }
 
     /**
@@ -262,7 +264,7 @@ public class FDFDocument implements Clos
      */
     public void save(String fileName) throws IOException
     {
-        save(new FileOutputStream(fileName));
+        save(new File(fileName));
     }
 
     /**
@@ -299,8 +301,10 @@ public class FDFDocument implements Clos
      */
     public void saveXFDF(File fileName) throws IOException
     {
-        saveXFDF(new BufferedWriter(
-                new OutputStreamWriter(new FileOutputStream(fileName), "UTF-8")));
+        BufferedWriter writer = new BufferedWriter(
+                new OutputStreamWriter(new FileOutputStream(fileName), "UTF-8"));
+        saveXFDF(writer);
+        writer.close();
     }
 
     /**
@@ -312,8 +316,7 @@ public class FDFDocument implements Clos
      */
     public void saveXFDF(String fileName) throws IOException
     {
-        saveXFDF(new BufferedWriter(
-                new OutputStreamWriter(new FileOutputStream(fileName), "UTF-8")));
+        saveXFDF(new File(fileName));
     }
 
     /**