You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by John Hjelmstad <jo...@gmail.com> on 2010/03/17 19:14:15 UTC
Re: Add the osml feature (issue593044)
Hi Chirag:
Looks like the base URL you set for this CL still includes "incubator" --
could you remove that and confirm when done?
Thanks,
John
On Wed, Mar 17, 2010 at 8:53 AM, <ch...@gmail.com> wrote:
> Reviewers: shindig.remailer_gmail.com,
>
> Description:
> The osml feature signals TemplateRewriter to only process OSML tags, a
> strict subset of OpenSocial Templating. This is defined by section 3 of
> the OpenSocial Markup Language Tags Specification v0.9
>
> Spec:
>
> http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3
>
> Please review this at http://codereview.appspot.com/593044/show
>
> Affected files:
> features/src/main/javascript/features/features.txt
> features/src/main/javascript/features/osml/feature.xml
>
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
>
> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
>
>
>
Re: Add the osml feature (issue593044)
Posted by Paul Lindner <li...@inuus.com>.
I added the correct trunk to the repos list on codereview as:
*trunk* Shindig - ** Correct Trunk as of 02/2010
http://svn.apache.org/repos/asf/shindig/trunk/
Can whoever made the original branches go back and mark them obsolete? Then
I can give it a less dorky name.
Thanks...
On Wed, Mar 17, 2010 at 11:45 AM, Henry Saputra <he...@gmail.com>wrote:
> I think if you use set Base manually like John did it should work. However
> if you select from existing SVN base for Shindig it wont since they still
> points to incubator urls.
>
> - Henry
>
> On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <johnfargo@gmail.com
> >wrote:
>
> > Hi Chirag:
> >
> > Looks like the base URL you set for this CL still includes "incubator" --
> > could you remove that and confirm when done?
> >
> > Thanks,
> > John
> >
> > On Wed, Mar 17, 2010 at 8:53 AM, <ch...@gmail.com> wrote:
> >
> > > Reviewers: shindig.remailer_gmail.com,
> > >
> > > Description:
> > > The osml feature signals TemplateRewriter to only process OSML tags, a
> > > strict subset of OpenSocial Templating. This is defined by section 3 of
> > > the OpenSocial Markup Language Tags Specification v0.9
> > >
> > > Spec:
> > >
> > >
> >
> http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3
> > >
> > > Please review this at http://codereview.appspot.com/593044/show
> > >
> > > Affected files:
> > > features/src/main/javascript/features/features.txt
> > > features/src/main/javascript/features/osml/feature.xml
> > >
> > >
> >
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
> > >
> > >
> >
> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
> > >
> > >
> > >
> >
>
Re: Add the osml feature (issue593044)
Posted by Henry Saputra <he...@gmail.com>.
I think if you use set Base manually like John did it should work. However
if you select from existing SVN base for Shindig it wont since they still
points to incubator urls.
- Henry
On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <jo...@gmail.com>wrote:
> Hi Chirag:
>
> Looks like the base URL you set for this CL still includes "incubator" --
> could you remove that and confirm when done?
>
> Thanks,
> John
>
> On Wed, Mar 17, 2010 at 8:53 AM, <ch...@gmail.com> wrote:
>
> > Reviewers: shindig.remailer_gmail.com,
> >
> > Description:
> > The osml feature signals TemplateRewriter to only process OSML tags, a
> > strict subset of OpenSocial Templating. This is defined by section 3 of
> > the OpenSocial Markup Language Tags Specification v0.9
> >
> > Spec:
> >
> >
> http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3
> >
> > Please review this at http://codereview.appspot.com/593044/show
> >
> > Affected files:
> > features/src/main/javascript/features/features.txt
> > features/src/main/javascript/features/osml/feature.xml
> >
> >
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
> >
> >
> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
> >
> >
> >
>
Re: Add the osml feature (issue593044)
Posted by John Hjelmstad <jo...@gmail.com>.
Odd, I use "Shindig - *trunk* - Real Trunk" and be sure to specify Base: "
http://svn.apache.org/repos/asf/shindig/trunk/" when creating new entries,
which seems to work fine for me. I use the web UI rather than upload.py
On Wed, Mar 17, 2010 at 11:24 AM, Henry Saputra <he...@gmail.com>wrote:
> HI John,
>
> I think its because the url for repository in the codereview still points
> to incubator.
>
> I can add a new branch for the new shindig trunk repository url but its
> better to change the existing "real trunk" and "trunk" repository.
>
> Since I didnt created the shindig trunk repositories I cant modified them.
>
> - Henry
>
>
> On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <jo...@gmail.com>wrote:
>
>> Hi Chirag:
>>
>> Looks like the base URL you set for this CL still includes "incubator" --
>> could you remove that and confirm when done?
>>
>> Thanks,
>> John
>>
>> On Wed, Mar 17, 2010 at 8:53 AM, <ch...@gmail.com> wrote:
>>
>> > Reviewers: shindig.remailer_gmail.com,
>> >
>> > Description:
>> > The osml feature signals TemplateRewriter to only process OSML tags, a
>> > strict subset of OpenSocial Templating. This is defined by section 3 of
>> > the OpenSocial Markup Language Tags Specification v0.9
>> >
>> > Spec:
>> >
>> >
>> http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3
>> >
>> > Please review this at http://codereview.appspot.com/593044/show
>> >
>> > Affected files:
>> > features/src/main/javascript/features/features.txt
>> > features/src/main/javascript/features/osml/feature.xml
>> >
>> >
>> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
>> >
>> >
>> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
>> >
>> >
>> >
>>
>
>
Re: Add the osml feature (issue593044)
Posted by Henry Saputra <he...@gmail.com>.
HI John,
I think its because the url for repository in the codereview still points to
incubator.
I can add a new branch for the new shindig trunk repository url but its
better to change the existing "real trunk" and "trunk" repository.
Since I didnt created the shindig trunk repositories I cant modified them.
- Henry
On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <jo...@gmail.com>wrote:
> Hi Chirag:
>
> Looks like the base URL you set for this CL still includes "incubator" --
> could you remove that and confirm when done?
>
> Thanks,
> John
>
> On Wed, Mar 17, 2010 at 8:53 AM, <ch...@gmail.com> wrote:
>
> > Reviewers: shindig.remailer_gmail.com,
> >
> > Description:
> > The osml feature signals TemplateRewriter to only process OSML tags, a
> > strict subset of OpenSocial Templating. This is defined by section 3 of
> > the OpenSocial Markup Language Tags Specification v0.9
> >
> > Spec:
> >
> >
> http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3
> >
> > Please review this at http://codereview.appspot.com/593044/show
> >
> > Affected files:
> > features/src/main/javascript/features/features.txt
> > features/src/main/javascript/features/osml/feature.xml
> >
> >
> java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
> >
> >
> java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
> >
> >
> >
>