You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/10/15 23:46:46 UTC
[jira] Created: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not revert corrupted information
FSDataset.getStoredBlock(id) should not revert corrupted information
--------------------------------------------------------------------
Key: HADOOP-4423
URL: https://issues.apache.org/jira/browse/HADOOP-4423
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
Priority: Blocker
Fix For: 0.19.0
If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Attachment: 4423_20081016b.patch
4423_20081016b.patch: use Namenode block length for recovering blocks in the beginning of append.
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4423:
------------------------------------
Release Note: (was: Added a new parameter keepLength to ClientDatanodeProtocol.recoverBlock(...))
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch, 4423_20081017.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640871#action_12640871 ]
Hudson commented on HADOOP-4423:
--------------------------------
Integrated in Hadoop-trunk #637 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/637/])
. Keep block length when the block recovery is triggered by append. (szetszwo)
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch, 4423_20081017.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Attachment: 4423_20081016.patch
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4423_20081016.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Status: Patch Available (was: Open)
On a second thought, 10.18 does not need this since 0.18 does not have append. Do you agree, Dhruba?
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640532#action_12640532 ]
Hadoop QA commented on HADOOP-4423:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12392285/4423_20081016b.patch
against trunk revision 705552.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3483/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3483/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3483/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3483/console
This message is automatically generated.
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler reassigned HADOOP-4423:
---------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4423_20081016.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Attachment: 4423_20081017.patch
4423_20081017.patch: updated with trunk, no code changes.
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch, 4423_20081017.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4423:
------------------------------------
Hadoop Flags: [Reviewed] (was: [Reviewed, Incompatible change])
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch, 4423_20081017.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640346#action_12640346 ]
dhruba borthakur commented on HADOOP-4423:
------------------------------------------
+1 on the code change. We do not need this fix for 0.18.
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Incompatible change, Reviewed] (was: [Reviewed, Incompatible change])
Status: Resolved (was: Patch Available)
I just committed this.
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch, 4423_20081017.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Fix Version/s: (was: 0.18.2)
Release Note: Added a new parameter keepLength to ClientDatanodeProtocol.recoverBlock(...)
Hadoop Flags: [Incompatible change, Reviewed]
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 4423_20081016.patch, 4423_20081016b.patch
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4423) FSDataset.getStoredBlock(id) should
not return corrupted information
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4423:
-------------------------------------------
Fix Version/s: 0.18.2
Summary: FSDataset.getStoredBlock(id) should not return corrupted information (was: FSDataset.getStoredBlock(id) should not revert corrupted information)
This problem is also in 0.18
> FSDataset.getStoredBlock(id) should not return corrupted information
> --------------------------------------------------------------------
>
> Key: HADOOP-4423
> URL: https://issues.apache.org/jira/browse/HADOOP-4423
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
>
> If a block file is corrupted so that the length is changed, FSDataset.getStoredBlock(id) will return a Block object with the corrupted length.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.