You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Miguel Ferreira <mi...@me.com> on 2014/07/21 15:42:12 UTC
Review Request 23737: Improve usability of deployDataCenter.py and advanced
zone config
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23737/
-----------------------------------------------------------
Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Wei Zhou.
Repository: cloudstack-git
Description
-------
Added step-wise log messages during deploy data center.
Also reordered some parameters in the advanced zone config for better readability.
Diffs
-----
tools/devcloud/devcloud-advanced.cfg 74b6366
tools/marvin/marvin/deployDataCenter.py ae48839
Diff: https://reviews.apache.org/r/23737/diff/
Testing
-------
Used deployDataCenter.py together with advanced zone config to deploy a zone in my development environment
Thanks,
Miguel Ferreira
Re: Review Request 23737: Improve usability of deployDataCenter.py and
advanced zone config
Posted by Miguel Ferreira <mi...@me.com>.
> On July 21, 2014, 2:12 p.m., Santhosh Edukulla wrote:
> > tools/devcloud/devcloud-advanced.cfg, line 86
> > <https://reviews.apache.org/r/23737/diff/1/?file=636764#file636764line86>
> >
> > whats the significance of this change?
As I said in the description, I reordered some parameters to increase readability. for instance having startip before endip, I think, increases readability.
> On July 21, 2014, 2:12 p.m., Santhosh Edukulla wrote:
> > tools/devcloud/devcloud-advanced.cfg, line 126
> > <https://reviews.apache.org/r/23737/diff/1/?file=636764#file636764line126>
> >
> > Instead of these elements, please use advanced.cfg for reference and use logger element in similar, now marvin and test cases as such do not worry about testclient.log or testcase.log. Instead, logging was simplified to dump failed exception logs, run log and result log for each test suite, these elements can be removed, but log path can still be used.
I did not introduce that. The elements were already there.
- Miguel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23737/#review48219
-----------------------------------------------------------
On July 21, 2014, 1:42 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23737/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:42 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Wei Zhou.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added step-wise log messages during deploy data center.
>
> Also reordered some parameters in the advanced zone config for better readability.
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/marvin/marvin/deployDataCenter.py ae48839
>
> Diff: https://reviews.apache.org/r/23737/diff/
>
>
> Testing
> -------
>
> Used deployDataCenter.py together with advanced zone config to deploy a zone in my development environment
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23737: Improve usability of deployDataCenter.py and
advanced zone config
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23737/#review48219
-----------------------------------------------------------
tools/devcloud/devcloud-advanced.cfg
<https://reviews.apache.org/r/23737/#comment84577>
whats the significance of this change?
tools/devcloud/devcloud-advanced.cfg
<https://reviews.apache.org/r/23737/#comment84575>
Instead of these elements, please use advanced.cfg for reference and use logger element in similar, now marvin and test cases as such do not worry about testclient.log or testcase.log. Instead, logging was simplified to dump failed exception logs, run log and result log for each test suite, these elements can be removed, but log path can still be used.
- Santhosh Edukulla
On July 21, 2014, 1:42 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23737/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:42 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Wei Zhou.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added step-wise log messages during deploy data center.
>
> Also reordered some parameters in the advanced zone config for better readability.
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/marvin/marvin/deployDataCenter.py ae48839
>
> Diff: https://reviews.apache.org/r/23737/diff/
>
>
> Testing
> -------
>
> Used deployDataCenter.py together with advanced zone config to deploy a zone in my development environment
>
>
> Thanks,
>
> Miguel Ferreira
>
>
Re: Review Request 23737: Improve usability of deployDataCenter.py and
advanced zone config
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23737/#review79039
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On July 21, 2014, 1:42 p.m., Miguel Ferreira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23737/
> -----------------------------------------------------------
>
> (Updated July 21, 2014, 1:42 p.m.)
>
>
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Wei Zhou.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added step-wise log messages during deploy data center.
>
> Also reordered some parameters in the advanced zone config for better readability.
>
>
> Diffs
> -----
>
> tools/devcloud/devcloud-advanced.cfg 74b6366
> tools/marvin/marvin/deployDataCenter.py ae48839
>
> Diff: https://reviews.apache.org/r/23737/diff/
>
>
> Testing
> -------
>
> Used deployDataCenter.py together with advanced zone config to deploy a zone in my development environment
>
>
> Thanks,
>
> Miguel Ferreira
>
>