You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2023/01/04 05:11:02 UTC

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8732: [IOTDB-4497] Improve NodeStatus definition

CRZbulabula opened a new pull request, #8732:
URL: https://github.com/apache/iotdb/pull/8732

   Add more detailed NodeStatus definition on user docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8732: [IOTDB-4497] Improve NodeStatus definition

Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #8732:
URL: https://github.com/apache/iotdb/pull/8732#discussion_r1061403933


##########
docs/UserGuide/Cluster/Cluster-Maintenance.md:
##########
@@ -82,6 +82,8 @@ The ConfigNode statuses are defined as follows:
 
 - **Running**: The ConfigNode is running properly.
 - **Unknown**: The ConfigNode doesn't report heartbeat properly.
+  - Can't receive data synchronized from other ConfigNodes

Review Comment:
   This is an attributive clause that leaves out that~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] Beyyes commented on a diff in pull request #8732: [IOTDB-4497] Improve NodeStatus definition

Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #8732:
URL: https://github.com/apache/iotdb/pull/8732#discussion_r1061310334


##########
docs/zh/UserGuide/Cluster/Cluster-Maintenance.md:
##########
@@ -130,8 +132,13 @@ DataNode 的状态机如下图所示：
 
 - **Running**: DataNode 正常运行，可读可写
 - **Unknown**: DataNode 未正常上报心跳，ConfigNode 认为该 DataNode 不可读写
+  - 少数 DataNode Unknown 不影响集群读写
 - **Removing**: DataNode 正在移出集群，不可读写
+  - 少数 DataNode Removing 不影响集群读写 
 - **ReadOnly**: DataNode 磁盘剩余空间低于 disk_warning_threshold（默认 5%），DataNode 可读但不能写入，不能同步数据
+  - 少数 DataNode ReadOnly 不影响集群读写
+  - ReadOnly 状态下可以删除元数据和数据，可以删除 Database
+  - 所有 DataNode 处于 ReadOnly 状态时，集群不可写入元数据和数据，仍可以创建 Database

Review Comment:
   是否可删除数据？
   能否列个表格注明各种情况下是否可读、写、删数据



##########
docs/UserGuide/Cluster/Cluster-Maintenance.md:
##########
@@ -82,6 +82,8 @@ The ConfigNode statuses are defined as follows:
 
 - **Running**: The ConfigNode is running properly.
 - **Unknown**: The ConfigNode doesn't report heartbeat properly.
+  - Can't receive data synchronized from other ConfigNodes

Review Comment:
   synchronized is adj. or v.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8732: [IOTDB-4497] Improve NodeStatus definition

Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #8732:
URL: https://github.com/apache/iotdb/pull/8732#discussion_r1061403510


##########
docs/zh/UserGuide/Cluster/Cluster-Maintenance.md:
##########
@@ -130,8 +132,13 @@ DataNode 的状态机如下图所示：
 
 - **Running**: DataNode 正常运行，可读可写
 - **Unknown**: DataNode 未正常上报心跳，ConfigNode 认为该 DataNode 不可读写
+  - 少数 DataNode Unknown 不影响集群读写
 - **Removing**: DataNode 正在移出集群，不可读写
+  - 少数 DataNode Removing 不影响集群读写 
 - **ReadOnly**: DataNode 磁盘剩余空间低于 disk_warning_threshold（默认 5%），DataNode 可读但不能写入，不能同步数据
+  - 少数 DataNode ReadOnly 不影响集群读写
+  - ReadOnly 状态下可以删除元数据和数据，可以删除 Database
+  - 所有 DataNode 处于 ReadOnly 状态时，集群不可写入元数据和数据，仍可以创建 Database

Review Comment:
   Added~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] CRZbulabula merged pull request #8732: [IOTDB-4497] Improve NodeStatus definition

Posted by GitBox <gi...@apache.org>.
CRZbulabula merged PR #8732:
URL: https://github.com/apache/iotdb/pull/8732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org