[GitHub] [geode] dschneider-pivotal opened pull request #3401: GEODE-6593: fix test elapsed time computation

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The test was using System.currentTimeMillis to verify that
the product has blocked for as long as expected.
But the product is using System.nanoTime.
This can cause race conditions because these two different
clocks can be updated at different times.
The test now also uses System.nanoTime.
Also removed some dead test code.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on issue #3401: GEODE-6593: fix test elapsed time computation

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Thanks for the feedback. I have added time unit suffixes and 100ms of wiggle room

[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3401: GEODE-6593: fix test elapsed time computation

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

No! Thanks for catching it

[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] balesh2 commented on pull request #3401: GEODE-6593: fix test elapsed time computation

["balesh2 (GitHub)" <gi...@apache.org>]

Did you mean to leave this in?

[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #3401: GEODE-6593: fix test elapsed time computation

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

Using TimeUnit constants avoids confusion in math too. https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/TimeUnit.html

[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #3401: GEODE-6593: fix test elapsed time computation

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3401 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org