You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ErnieAllen <gi...@git.apache.org> on 2018/11/08 12:44:37 UTC
[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
GitHub user ErnieAllen opened a pull request:
https://github.com/apache/qpid-dispatch/pull/415
DISPATCH-1176 Prevent uninitialized delivery from crashing router
This prevents the crash but... I'm concerned about router inter-operability between different versions of the router.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #415
----
commit 51a02e6a5de6907c14df24db7cd51475e45f2ea6
Author: Ernest Allen <ea...@...>
Date: 2018-11-08T12:40:53Z
DISPATCH-1176 Prevent uninitialized delivery from crashing router
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/415#discussion_r232058603
--- Diff: src/router_core/router_core_private.h ---
@@ -321,7 +321,8 @@ ALLOC_DECLARE(qdr_router_ref_t);
DEQ_DECLARE(qdr_router_ref_t, qdr_router_ref_list_t);
typedef enum {
- QDR_DELIVERY_NOWHERE = 0,
+ QDR_DELIVERY_UNINITIALIZED = 0,
+ QDR_DELIVERY_NOWHERE,
--- End diff --
I claim that QDR_DELIVERY_NOWHERE is the proper default value for this type. This type is used to indicate in which list a particular delivery is contained. If it has never been inserted into a list, it should indicate NOWHERE.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/415
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #415: DISPATCH-1176 Prevent uninitialized deliver...
Posted by ErnieAllen <gi...@git.apache.org>.
Github user ErnieAllen commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/415#discussion_r232223312
--- Diff: src/router_core/router_core_private.h ---
@@ -321,7 +321,8 @@ ALLOC_DECLARE(qdr_router_ref_t);
DEQ_DECLARE(qdr_router_ref_t, qdr_router_ref_list_t);
typedef enum {
- QDR_DELIVERY_NOWHERE = 0,
+ QDR_DELIVERY_UNINITIALIZED = 0,
+ QDR_DELIVERY_NOWHERE,
--- End diff --
New commit just uses QDR_DELIVERY_NOWHERE as the test in transfer.c::qdr_deliver_continue_CT to reject the delivery.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #415: DISPATCH-1176 Prevent uninitialized delivery from ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/415
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@421a3db`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #415 +/- ##
=========================================
Coverage ? 85.67%
=========================================
Files ? 81
Lines ? 17864
Branches ? 0
=========================================
Hits ? 15305
Misses ? 2559
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/415/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.61% <100%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=footer). Last update [421a3db...51a02e6](https://codecov.io/gh/apache/qpid-dispatch/pull/415?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org