[GitHub] [pulsar] HQebupt commented on a change in pull request #13563: [Improvement] Recycler should use io.netty.recycler.maxCapacityPerThread instead of io.netty.recycler.maxCapacity.default as maxCapacityPerThread configuration in Netty 4.1.x

[GitBox <gi...@apache.org>]

HQebupt commented on a change in pull request #13563:
URL: https://github.com/apache/pulsar/pull/13563#discussion_r802241948



##########
File path: conf/bkenv.sh
##########
@@ -48,7 +48,7 @@ else
 fi
 
 # Extra options to be passed to the jvm
-BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS:-"-Dio.netty.leakDetectionLevel=disabled ${PULSAR_EXTRA_OPTS:-"-Dio.netty.recycler.maxCapacity.default=1000 -Dio.netty.recycler.linkCapacity=1024"}"}"
+BOOKIE_EXTRA_OPTS="${BOOKIE_EXTRA_OPTS:-"-Dio.netty.leakDetectionLevel=disabled ${PULSAR_EXTRA_OPTS:-"-Dio.netty.recycler.maxCapacityPerThread=4096 -Dio.netty.recycler.linkCapacity=1024"}"}"

Review comment:
       @michaeljmarshall  @315157973  The `io.netty.recycler.maxCapacity.default=1000` is invalid. It means the configuration does not work. And by default `io.netty.recycler.maxCapacityPerThread` is 4096. I explicitly point out here.  Please refer https://github.com/netty/netty/blob/d5faba2fbeb7da65daa0a10f41560f47443c1026/common/src/main/java/io/netty/util/Recycler.java#L49 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org