You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/05/11 16:44:46 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #35146: GH-29781: [C++][Parquet] Switch to use compliant nested types by default

pitrou commented on code in PR #35146:
URL: https://github.com/apache/arrow/pull/35146#discussion_r1191447731


##########
cpp/src/parquet/properties.h:
##########
@@ -938,13 +937,13 @@ class PARQUET_EXPORT ArrowWriterProperties {
     /// list types (default "item"), will use "entries", as is specified in

Review Comment:
   It seems this docstring is incorrect as per the Parquet spec, or am I reading it wrong?
   ```suggestion
       /// list types (default "item"), will use "element", as is specified in
   ```
   
   See https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org