You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/02/12 15:40:37 UTC

[GitHub] [qpid-dispatch] kgiusti opened a new pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

kgiusti opened a new pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680
 
 
   Adding Ssorj as this patch surfaces a new management entity (memoryUsage)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378899864
 
 

 ##########
 File path: src/dispatch.c
 ##########
 @@ -379,3 +379,50 @@ void qd_dispatch_router_unlock(qd_dispatch_t *qd) { sys_mutex_unlock(qd->router-
 qdr_core_t* qd_dispatch_router_core(qd_dispatch_t *qd) {
     return qd->router->router_core;
 }
+
+
+/* qd_router_memory_usage
+ *
+ * Return the amount of memory currently provisioned by the qdrouterd process.
+ * This includes data, stack, and code memory.  On systems supporting virtual
+ * memory this value may be larger than the physical RAM available on the
+ * platform.
+ *
+ * Return 0 if the memory usage cannot be determined.
+ */
+uint64_t qd_router_memory_usage()
+{
+    // @TODO(kgiusti): only works for linux (what? doesn't everyone run linux?)
+
+    // parse the VmSize value out of the /proc/[pid]/status file
+    const pid_t my_pid = getpid();
+    const char *status_template = "/proc/%ld/status";
+    char status_path[64];
+    if (snprintf(status_path, 64, status_template, (long int)my_pid) >= 64) {
 
 Review comment:
   Not necessarily - safe_snprintf ensures the return value reflects the # of bytes written to the buffer.  Here we want to detect overflow so are relying on a return code that is >= the buffer size.  So here the use of snprintf is about as safe as it can be (esp given that any valid value for the pid won't overflow the buffer in the first place).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378372489
 
 

 ##########
 File path: src/dispatch.c
 ##########
 @@ -379,3 +379,50 @@ void qd_dispatch_router_unlock(qd_dispatch_t *qd) { sys_mutex_unlock(qd->router-
 qdr_core_t* qd_dispatch_router_core(qd_dispatch_t *qd) {
     return qd->router->router_core;
 }
+
+
+/* qd_router_memory_usage
+ *
+ * Return the amount of memory currently provisioned by the qdrouterd process.
+ * This includes data, stack, and code memory.  On systems supporting virtual
+ * memory this value may be larger than the physical RAM available on the
+ * platform.
+ *
+ * Return 0 if the memory usage cannot be determined.
+ */
+uint64_t qd_router_memory_usage()
+{
+    // @TODO(kgiusti): only works for linux (what? doesn't everyone run linux?)
+
+    // parse the VmSize value out of the /proc/[pid]/status file
+    const pid_t my_pid = getpid();
+    const char *status_template = "/proc/%ld/status";
+    char status_path[64];
+    if (snprintf(status_path, 64, status_template, (long int)my_pid) >= 64) {
 
 Review comment:
   Should we used the safe_snprintf instead of snprintf ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report
   > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/680/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #680      +/-   ##
   ==========================================
   + Coverage   86.83%   86.87%   +0.03%     
   ==========================================
     Files          92       92              
     Lines       21047    21069      +22     
   ==========================================
   + Hits        18277    18304      +27     
   + Misses       2770     2765       -5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.42% <80%> (-0.59%)` | :arrow_down: |
   | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.73% <89.47%> (+0.57%)` | :arrow_up: |
   | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (-0.12%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88% <0%> (-0.03%)` | :arrow_down: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (+0.16%)` | :arrow_up: |
   | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.22% <0%> (+0.56%)` | :arrow_up: |
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.68%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...51d0c85](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report
   > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `90.9%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/680/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #680      +/-   ##
   ==========================================
   - Coverage   86.83%   86.81%   -0.02%     
   ==========================================
     Files          92       92              
     Lines       21047    21069      +22     
   ==========================================
   + Hits        18277    18292      +15     
   - Misses       2770     2777       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: |
   | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: |
   | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.24% <0%> (ø)` | :arrow_up: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: |
   | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7ffdc61](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585374303
 
 
   Please push commits one by one so we can see the diff between each commit. You can squash all the commits before committing to master

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report
   > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/b282a284d6853acd14386f33a60d8b079dec93ec?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `90.9%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/680/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #680      +/-   ##
   ==========================================
   + Coverage   86.83%   86.86%   +0.02%     
   ==========================================
     Files          92       92              
     Lines       21047    21069      +22     
   ==========================================
   + Hits        18277    18301      +24     
   + Misses       2770     2768       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `91.2% <100%> (+0.19%)` | :arrow_up: |
   | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.8% <90%> (+0.65%)` | :arrow_up: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: |
   | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `79.94% <0%> (-0.59%)` | :arrow_down: |
   | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.41% <0%> (-0.38%)` | :arrow_down: |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.58% <0%> (-0.34%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.63% <0%> (-0.13%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.12% <0%> (-0.12%)` | :arrow_down: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.36% <0%> (+0.18%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [b282a28...7694b99](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report
   > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/82166ab472c81adec9e73c66d744738e9f120c1c?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/680/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #680      +/-   ##
   ==========================================
   - Coverage   86.85%   86.82%   -0.03%     
   ==========================================
     Files          92       92              
     Lines       21098    21124      +26     
   ==========================================
   + Hits        18324    18341      +17     
   - Misses       2774     2783       +9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.42% <80%> (-0.59%)` | :arrow_down: |
   | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.73% <89.47%> (+0.57%)` | :arrow_up: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: |
   | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.16% <0%> (-0.19%)` | :arrow_down: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.17%)` | :arrow_down: |
   | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.69% <0%> (-0.13%)` | :arrow_down: |
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.9% <0%> (-0.1%)` | :arrow_down: |
   | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.09% <0%> (+0.11%)` | :arrow_up: |
   | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.79% <0%> (+0.37%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [82166ab...17b6305](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378371077
 
 

 ##########
 File path: tools/qdstat.in
 ##########
 @@ -325,6 +333,13 @@ class BusManager(Node):
             rows.append(('Uptime',        TimeLong(router.uptimeSeconds)))
         except:
             pass
+        try:
 
 Review comment:
   Should this show in the output of qdstat -m instead of qdstat -g ?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378351698
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -614,7 +614,12 @@
                     "type": "integer",
                     "graph": true,
                     "description": "The number of seconds since the router was started."
-                }                
+                },
+                "memoryUsage": {
+                    "type": "integer",
+                    "graph": true,
+                    "description": "The current amount of memory in use by the qdrouterd process in bytes.  This includes memory provisioned for stack, data, and code.  This value is set to zero if the platform does not provide access to the process memory size."
 
 Review comment:
   Could mention that the value corresponds to 'VmSize'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#discussion_r378355488
 
 

 ##########
 File path: tools/qdstat.in
 ##########
 @@ -728,6 +743,17 @@ class BusManager(Node):
         dispRows = sorter.getSorted()
         disp.formattedTable(title, heads, dispRows)
 
+        # attempt to get the qdrouterd process memory usage
+        # this may not be present on all platforms
+        try:
+            objects = self.query('org.apache.qpid.dispatch.router', ['memoryUsage'])
+            mem = objects[0].memoryUsage
+        except Exception:
+            mem = 0
+
+        if mem != 0:
+            print("\nProcess memory usage: %s" % self._mem_as_mb_str(mem))
 
 Review comment:
   This doesn't print the MB unit specifier as in the -g table
   This doesn't quote the values when --csv is in effect. I'd expect "Process memory usage:","520.2 MB" in that case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] kgiusti merged pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
kgiusti merged pull request #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #680: DISPATCH-1415, DISPATCH-1569: add process memory metric
URL: https://github.com/apache/qpid-dispatch/pull/680#issuecomment-585394446
 
 
   # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=h1) Report
   > Merging [#680](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/a56b28ccb1b552c5b2dc0872dcde1fa09c725cab?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/680/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #680      +/-   ##
   =========================================
   + Coverage   86.89%   86.9%   +<.01%     
   =========================================
     Files          92      92              
     Lines       21047   21070      +23     
   =========================================
   + Hits        18288   18310      +22     
   - Misses       2759    2760       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j) | `90.42% <80%> (-0.59%)` | :arrow_down: |
   | [src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2Rpc3BhdGNoLmM=) | `83.73% <89.47%> (+0.57%)` | :arrow_up: |
   | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.41% <0%> (-0.49%)` | :arrow_down: |
   | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.8% <0%> (-0.23%)` | :arrow_down: |
   | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.69% <0%> (-0.23%)` | :arrow_down: |
   | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: |
   | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.9% <0%> (+0.09%)` | :arrow_up: |
   | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: |
   | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.45%)` | :arrow_up: |
   | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/680/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `87.09% <0%> (+1.61%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=footer). Last update [a56b28c...9f57830](https://codecov.io/gh/apache/qpid-dispatch/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org