[GitHub] [hadoop-ozone] elek commented on pull request #1374: HDDS-4185. Remove IncrementalByteBuffer from Ozone client

[GitBox <gi...@apache.org>]

elek commented on pull request #1374:
URL: https://github.com/apache/hadoop-ozone/pull/1374#issuecomment-684895095


   The key line is this:
   
   ```
   int effectiveBufferSize = Math.min(bufferSize, maxSize - bufferList.size() * bufferSize);
   ```
   
   If the block/key is smaller than the `BuffferPool` (16 * 4MB) we allocate only the required bytes.(last buffer in the pool is reduced by this `effectiveBufferSize`).
   
   If block size is bigger than the `BufferPool`, we need to allocate the full `BufferPool` anyway.
   
   cc @bshashikant 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org