You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "petersomogyi (via GitHub)" <gi...@apache.org> on 2025/10/07 13:28:35 UTC
[PR] HBASE-29646 TableReporter compatibility with HBase 3.0 [hbase-operator-tools]
petersomogyi opened a new pull request, #153:
URL: https://github.com/apache/hbase-operator-tools/pull/153
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29646 TableReporter compatibility with HBase 3.0 [hbase-operator-tools]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #153:
URL: https://github.com/apache/hbase-operator-tools/pull/153#issuecomment-3376987172
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 39s | master passed |
| +1 :green_heart: | compile | 0m 6s | master passed |
| +1 :green_heart: | checkstyle | 0m 13s | master passed |
| +1 :green_heart: | spotless | 0m 10s | branch has no errors when running spotless:check. |
| +1 :green_heart: | javadoc | 0m 13s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 18s | the patch passed |
| +1 :green_heart: | compile | 0m 9s | the patch passed |
| +1 :green_heart: | javac | 0m 9s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 5s | the patch passed |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | spotless | 0m 7s | patch has no errors when running spotless:check. |
| +1 :green_heart: | javadoc | 0m 8s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 10s | hbase-table-reporter in the patch passed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 6m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-153/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/153 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs spotless checkstyle compile |
| uname | Linux fbd56f07e510 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/jenkins/hbase-personality.sh |
| git revision | master / a441c11 |
| Default Java | Oracle Corporation-1.8.0_342-b07 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-153/1/testReport/ |
| Max. process+thread count | 38 (vs. ulimit of 5000) |
| modules | C: hbase-table-reporter U: hbase-table-reporter |
| Console output | https://ci-hbase.apache.org/job/HBase-Operator-Tools-PreCommit/job/PR-153/1/console |
| versions | git=2.30.2 maven=3.8.6 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29646 TableReporter compatibility with HBase 3.0 [hbase-operator-tools]
Posted by "petersomogyi (via GitHub)" <gi...@apache.org>.
petersomogyi merged PR #153:
URL: https://github.com/apache/hbase-operator-tools/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-29646 TableReporter compatibility with HBase 3.0 [hbase-operator-tools]
Posted by "petersomogyi (via GitHub)" <gi...@apache.org>.
petersomogyi commented on code in PR #153:
URL: https://github.com/apache/hbase-operator-tools/pull/153#discussion_r2410648280
##########
hbase-table-reporter/src/main/java/org/apache/hbase/reporter/TableReporter.java:
##########
@@ -317,55 +314,16 @@ public Thread newThread(Runnable r) {
}
/**
- * This is an estimate of the heap space occupied by a cell. When the cell is of type
- * {@link HeapSize} we call {@link HeapSize#heapSize()} so cell can give a correct value. In other
- * cases we just consider the bytes occupied by the cell components ie. row, CF, qualifier,
- * timestamp, type, value and tags. Note that this can be the JVM heap space (on-heap) or the OS
- * heap (off-heap)
- * @return estimate of the heap space
+ * Returns the heap space occupied by a cell. If the cell is of type {@link HeapSize}, calls
+ * {@link HeapSize#heapSize()} to get the value. Otherwise, returns 0. This value can represent
+ * either JVM heap space (on-heap) or OS heap (off-heap).
+ * @return the heap space used by the cell
*/
public static long estimatedSizeOfCell(final Cell cell) {
- if (cell instanceof HeapSize) {
- return ((HeapSize) cell).heapSize();
+ if (cell != null) {
+ return cell.heapSize();
}
- // TODO: Add sizing of references that hold the row, family, etc., arrays.
- return estimatedSerializedSizeOf(cell);
Review Comment:
Cell implements HeapSize so the `estimatedSerializedSizeOf` is never called. With this, the removed `cell.getTagsLength();` is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org