You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/05 14:19:24 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5283: ui: Fix failure in deletion of templates
Pearl1594 opened a new pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/5280, which fixes failure in deletion of templates
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Register a template and attempt deleting the template from a particular zone - It successfully deletes the template
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283#issuecomment-893761626
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5283 (SL-JID-482)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283#issuecomment-893758532
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283#issuecomment-893758838
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283#issuecomment-893759200
looks good @Pearl1594
Is this a regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5283: ui: Fix failure in deletion of templates
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5283:
URL: https://github.com/apache/cloudstack/pull/5283#issuecomment-893980796
Yes @DaanHoogland it is a regression - seems to have been caused by https://github.com/apache/cloudstack/pull/5034. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org