Re: cvs commit:jakarta-jetspeed/src/java/org/apache/jetspeed/services/psmlmanagerCastorPsmlManagerService.java

[Raphaël Luta <ra...@networks.groupvu.com>]

Jon Stevens wrote:
> 
> on 6/6/01 3:27 PM, "raphael@apache.org" <ra...@apache.org> wrote:
> 
> > +            f = new File(TurbineServlet.getRealPath(fileOrUrl));
> 
> This is not right. You should use TurbineConfig. Dependencies on
> TurbineServlet are bad.
> 

Huh, TurbineServlet is the service that encapsulates the ServletConfig (either real
or TurbineConfig) to provide access to it from anywhere in the code.
I don't understand how dependency on it could be bad (or you could use TurbineConfig
there for this matter).

(Since this is service, I could have stored a reference to the ServletConfig in
 init(ServletCOnfig) though)

--
Raphael Luta - raphael.luta@networks.groupvu.com
Vivendi Universal Networks - Paris

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org