You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/09/18 14:28:48 UTC
[kudu-CR] [tablet] Remove used state member
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14253
Change subject: [tablet] Remove used state member
......................................................................
[tablet] Remove used state member
Each type of transaction subclass (i.e. WriteTransaction
and AlterSchemaTransaction) uses its own state member,
so the state member of the base class is useless
Change-Id: I7d18063438905a5938cd6ae80f21179f0d6b0dd5
---
M src/kudu/tablet/transactions/alter_schema_transaction.cc
M src/kudu/tablet/transactions/transaction.cc
M src/kudu/tablet/transactions/transaction.h
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/write_transaction.cc
5 files changed, 10 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/14253/1
--
To view, visit http://gerrit.cloudera.org:8080/14253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d18063438905a5938cd6ae80f21179f0d6b0dd5
Gerrit-Change-Number: 14253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [tablet] Remove used state member
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14253 )
Change subject: [tablet] Remove used state member
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d18063438905a5938cd6ae80f21179f0d6b0dd5
Gerrit-Change-Number: 14253
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Sep 2019 16:42:52 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] Remove used state member
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14253 )
Change subject: [tablet] Remove used state member
......................................................................
[tablet] Remove used state member
Each type of transaction subclass (i.e. WriteTransaction
and AlterSchemaTransaction) uses its own state member,
so the state member of the base class is useless
Change-Id: I7d18063438905a5938cd6ae80f21179f0d6b0dd5
Reviewed-on: http://gerrit.cloudera.org:8080/14253
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tablet/transactions/alter_schema_transaction.cc
M src/kudu/tablet/transactions/transaction.cc
M src/kudu/tablet/transactions/transaction.h
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/write_transaction.cc
5 files changed, 10 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d18063438905a5938cd6ae80f21179f0d6b0dd5
Gerrit-Change-Number: 14253
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)