You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/02 23:16:47 UTC

Review Request: Updated all calls to 'strings::format' to remove need for invoking 'c_str()' on std::string arguments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5710/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  src/common/utils.hpp 93192e7 
  src/configurator/configuration.hpp 0abad77 
  src/master/master.cpp 89cdaf6 
  src/tests/strings_tests.cpp 53b037f 
  src/zookeeper/group.cpp a4a8b5a 

Diff: https://reviews.apache.org/r/5710/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request: Updated all calls to 'strings::format' to remove need for invoking 'c_str()' on std::string arguments.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5710/#review8843
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 2, 2012, 9:16 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5710/
> -----------------------------------------------------------
> 
> (Updated July 2, 2012, 9:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/utils.hpp 93192e7 
>   src/configurator/configuration.hpp 0abad77 
>   src/master/master.cpp 89cdaf6 
>   src/tests/strings_tests.cpp 53b037f 
>   src/zookeeper/group.cpp a4a8b5a 
> 
> Diff: https://reviews.apache.org/r/5710/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>