You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/03/12 02:15:38 UTC

[GitHub] spark pull request #20788: [SPARK-23647][PYTHON][SQL] Adds more types for hi...

Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20788#discussion_r173682841
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -437,10 +437,11 @@ def hint(self, name, *parameters):
             if not isinstance(name, str):
                 raise TypeError("name should be provided as str, got {0}".format(type(name)))
     
    +        allowed_types = (basestring, list, float, int)
    --- End diff --
    
    Should it be `basestring` or `str` as previously here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org