[jira] Commented: (MAPREDUCE-1128) MRUnit Allows Iteration Twice

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770797#action_12770797 ] 

Hadoop QA commented on MAPREDUCE-1128:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423386/MAPREDUCE-1128.patch
  against trunk revision 829529.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/94/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/94/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/94/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/94/console

This message is automatically generated.

> MRUnit Allows Iteration Twice
> -----------------------------
>
>                 Key: MAPREDUCE-1128
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1128
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>         Environment: Java 1.6, Hadoop 0.21.1+133 (cloudera distribution for hadoop)
>            Reporter: Ed Kohlwey
>            Assignee: Aaron Kimball
>            Priority: Minor
>         Attachments: MAPREDUCE-1128.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> MRUnit allows one to iterate over a collection of values twice (ie.
> reduce(Key key, Iterable<Value> values, Context context){
>    for(Value : values ) /* iterate once */;
>    for(Value : values ) /* iterate again */;
> }
> Hadoop will allow this as well, however the second iterator will be empty. MRUnit should either match hadoop's behavior or warn the user that their code is likely flawed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.