[GitHub] [spark] gemelen commented on a change in pull request #29286: [SPARK-21708][BUILD] Migrate build to sbt 1.x

[GitBox <gi...@apache.org>]

gemelen commented on a change in pull request #29286:
URL: https://github.com/apache/spark/pull/29286#discussion_r501345559



##########
File path: project/build.properties
##########
@@ -14,4 +14,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-sbt.version=0.13.18
+sbt.version=1.3.13

Review comment:
       Upgrade from 1.3.13 to 1.4 will require to remove compiler reporter snippet (pretty ancient one), otherwise build import fails on compilation error (sbt internals changed in related to this snippet classes). See this comment on why I skipped it in this PR - https://github.com/apache/spark/pull/29286#issuecomment-704546933.
   
   Just to give an impression - this is a starting point to unblock move to 1.4.0 https://github.com/apache/spark/commit/1e14d4aa8a38c11c3e46ea85c668b27d3106ad2c. After that one would need to fix a lot of warnings that are missed right now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org