You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2018/03/07 15:06:01 UTC

[GitHub] storm pull request #2589: [STORM-2989] LogCleaner should preserve current wo...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2589

    [STORM-2989] LogCleaner should preserve current worker.log.metrics

    https://issues.apache.org/jira/browse/STORM-2989
    
    Preserve current worker.log.metrics

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2989

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2589
    
----
commit 3a6f2043b840bfe647a48c04c93f460ebcb2688a
Author: Ethan Li <et...@...>
Date:   2018-03-07T15:03:44Z

    [STORM-2989] LogCleaner should preserve current worker.log.metrics

----


---

[GitHub] storm issue #2589: [STORM-2989] LogCleaner should preserve current worker.lo...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2589
  
    Thanks, merged to master. Cherry picked to 1.x and 1.1.x, and made the same change to the clojure logviewer there.


---

[GitHub] storm issue #2589: [STORM-2989] LogCleaner should preserve current worker.lo...

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2589
  
    The test failures should be unrelated. 


---

[GitHub] storm issue #2589: [STORM-2989] LogCleaner should preserve current worker.lo...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2589
  
    +1


---

[GitHub] storm pull request #2589: [STORM-2989] LogCleaner should preserve current wo...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2589


---