You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "matheusandre1 (via GitHub)" <gi...@apache.org> on 2026/04/29 02:47:18 UTC
[PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
matheusandre1 opened a new pull request, #6593:
URL: https://github.com/apache/camel-k/pull/6593
Closes: #6517
adds automatic error log checking the operator pod before deleting namespace, this helps detect potencial issues that might not be caught otherwise during test executtion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #6593:
URL: https://github.com/apache/camel-k/pull/6593#issuecomment-4358267220
All tests are broken:
```
test_support.go:2827:
ContainSubstring matcher requires a string or stringer. Got:
<func() string>: 0x241d0a0
```
please, run any test locally to make sure it works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #6593:
URL: https://github.com/apache/camel-k/pull/6593#issuecomment-4466367705
I had a second look and the original issue may not make totally sense, since logging an error condition could be a normal situation we want to handle. Closing this PR, thanks anyway for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #6593:
URL: https://github.com/apache/camel-k/pull/6593#issuecomment-4387283945
Given the checks failure, it seems that the check should be done in `func deleteTestNamespace(t *testing.T, ctx context.Context, ns ctrl.Object)` instead. Please, move the check in that func and rebase to clear the Kafka tests which have been fixed in `main` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #6593:
URL: https://github.com/apache/camel-k/pull/6593#issuecomment-4411997855
The fix is good. However we have certain tests failing because they have errors during execution. We must fix them along this PR adding commits which fix them. Anybody willing to contribute, can extend this PR, I'll mark as draft while we have the all fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #6593:
URL: https://github.com/apache/camel-k/pull/6593#discussion_r3159079383
##########
e2e/support/test_support.go:
##########
@@ -2811,6 +2812,8 @@ func userCleanup(t *testing.T) {
func invokeUserTestCode(t *testing.T, ctx context.Context, ns string, doRun func(context.Context, *gomega.WithT, string)) {
defer func() {
+ // Check for error logs before deleting the test namespace
+ checkOperatorErrorLogs(t, ctx, ns)
Review Comment:
This one could be simplified a lot via existing log check, for example:
```
g.Consistently(OperatorLogs(t, ctx, ns), 1*time.Minute, 3*time.Second).Should(Not(ContainSubstring("error")))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(tests): add error log checking for operator pod in user tests [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed pull request #6593: feat(tests): add error log checking for operator pod in user tests
URL: https://github.com/apache/camel-k/pull/6593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org