You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2016/02/16 20:01:22 UTC

[GitHub] flink pull request: [FLINK-3379] [FLINK-3415] [streaming] Refactor...

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/1646

    [FLINK-3379] [FLINK-3415] [streaming] Refactor TimestampExtractor

    This pull request divides the TimestampExtractor into two separate classes
     - one class handled periodic watermarks
     - the other class handled watermarks triggered by individual elements
    
    This also makes sure that any timestamp assigner / watermark generators cannot generate
    negative watermarks.
    
    This also adds tests for the operators that run the timestamp extractors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink refactor_extractors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1646.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1646
    
----
commit 1e3c4597dd1785430735950eef2b7b8c2154faaf
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-16T09:37:59Z

    [FLINK-3379] [FLINK-3415] [streaming] Refactor TimestampExtractor into two separate classes
    
     - one class handled periodic watermarks
     - the other class handled watermarks triggered by elements
    
    This also makes sure that any timestamp assigner / watermark generators cannot generate
    negative watermarks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3379] [FLINK-3415] [streaming] Refactor...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1646


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3379] [FLINK-3415] [streaming] Refactor...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1646#issuecomment-185116590
  
    I found a minor test flakeyness. Fixing that and merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3379] [FLINK-3415] [streaming] Refactor...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1646#issuecomment-185083361
  
    +1 This should go into 1.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---