You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mkurz (via GitHub)" <gi...@apache.org> on 2024/02/21 12:00:13 UTC
[PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
mkurz opened a new pull request, #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135
I am pretty sure this is safe since I am basically the on who maintains sbt-web and v1.5 is pretty much compatible with v1.4 API wise.
I use the same workaround in https://github.com/sbt/sbt-paradox-material-theme/blob/v0.7.0/project/plugins.sbt#L1-L3 actually
With this change I can `+Test/compile` pekko and I am not hitting https://repo.scala-sbt.org/ anymore (since I have blocked it on my machine).
@mdedetrich I am pretty sure this is ok to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135#issuecomment-1956674571
https://github.com/apache/incubator-pekko-http/pull/486 has an exclude on sbt-paradox 0.9.2 but this doesn't.
My preference is to try out the changes in https://github.com/apache/incubator-pekko-http and then when we are happy in that repo, we can copy the full set of changes to our other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135#issuecomment-1956508548
Running CI just to make sure but I am not expecting any surprises here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on PR #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135#issuecomment-1956551810
Oops sorry fixed formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use sbt-web 1.5.x despite staying on paradox 0.9.2 [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1135:
URL: https://github.com/apache/incubator-pekko/pull/1135#issuecomment-1958001824
> [apache/incubator-pekko-http#486](https://github.com/apache/incubator-pekko-http/pull/486) has an exclude on sbt-paradox 0.9.2 but this doesn't.
This exclude is no longer necessary on the latest version of pekko-sbt-paradox because of this change https://github.com/apache/incubator-pekko-sbt-paradox/pull/97. The exception here is if some other library brings in a later version of sbt-paradox/sbt-paradox-theme that overrides the 0.9.2 version which is JDK compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org