[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132176#comment-16132176 ] 

Sylvain Lebresne commented on CASSANDRA-13655:
----------------------------------------------

Sorry for the delay getting to this. It's definitively an oversight that range deletions are ignored for CAS. The patch lgtm, with just the following minor remarks:
* I'd rename {{CQL3CasRequest.SliceUpdate}} (and related {{addSliceUpdate()}} method) to {{RangeDeletion}} or something of the like. {{SliceUpdate}} is unnecessarily imprecise for what it is (I personally wouldn't merge it to {{RowUpdate}} however; having some private {{AbstractUpdate}} to combine the 3 common fields is an option but I'm honestly not sure it's worth the trouble).
* I agree with [~jay.zhuang]'s point #2 above, about moving the checks to a {{ModificationStatement.hasSlices()}} method. This is, after all, the conditions that are necessary to check before calling {{ModificationStatement.createSlices()}} so it would make it more explicit and we won't forget to change one of the 2 places if things evolve.
* It doesn't seem {{ModificationStatement.toSlices}} needs to be made package protected, it can stay private.
* There is a misplaced bracket [here|https://github.com/jeffjirsa/cassandra/commit/c2e3941352c1da31ba28f657974918ae46e81c97#diff-bee3b2111122530d9e0c5190e6773f62R462].

> Range deletes in a CAS batch are ignored
> ----------------------------------------
>
>                 Key: CASSANDRA-13655
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Blocker
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org