[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #1033: Create a separate file for a portable GeneralFormat

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence commented on code in PR #1033:
URL: https://github.com/apache/daffodil/pull/1033#discussion_r1227951724


##########
daffodil-core/src/test/scala/org/apache/daffodil/core/api/TestDsomCompiler3.scala:
##########
@@ -73,7 +73,7 @@ class TestDsomCompiler3 {
       // Verify things still work using specified tmpDir
       //
       val Seq(schema) = sset.schemas
-      val Seq(schemaDoc, _) = schema.schemaDocuments
+      val schemaDoc = schema.schemaDocuments.head

Review Comment:
   Yep, because there is now an extra include (GeneralFormatBase.xsd) there are now three docs in the `schema.schemaDocuments` list in a lot of tet. The first is still the root schema that we actually care about, but the pattern match fails. I figure switching to using `.head` will allow us to change the includes again if needed without breaking these tests, for example if IBM DFDL and Daffodil fix compatibility issues and the portable stuff goes away.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org