You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/07 20:30:48 UTC
[kudu-CR] [master path handlers] fix build on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13274
Change subject: [master_path_handlers] fix build on macOS
......................................................................
[master_path_handlers] fix build on macOS
This is a follow-up to fd6155fc00de48d17a65aafd79fbbad584a4f837.
After the patch mentioned above, but prior to fix this building on macOS
would fail with a linker error like below:
Undefined symbols for architecture x86_64:
"kudu::EasyJson& kudu::EasyJson::operator=<unsigned long>(unsigned long)", referenced from:
kudu::master::MasterPathHandlers::HandleTablePage(kudu::WebCallbackRegistry::WebRequest const&, kudu::WebCallbackRegistry::WebResponse*) in master_path_handlers.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
---
M src/kudu/master/master_path_handlers.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13274/1
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master path handlers] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/13274 )
Change subject: [master_path_handlers] fix build on macOS
......................................................................
Abandoned
Abandoned in favor of https://gerrit.cloudera.org/#/c/13281/
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [master path handlers] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13274 )
Change subject: [master_path_handlers] fix build on macOS
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc@331
PS2, Line 331: (*output)["column_count"] = static_cast<int64_t>(schema.num_columns());
> I suppose we ought to put a note here about why we're doing this random cas
I addressed that in https://gerrit.cloudera.org/#/c/13281/
Please take a look.
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 08 May 2019 07:40:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master path handlers] fix build on macOS
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13274 )
Change subject: [master_path_handlers] fix build on macOS
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/13274/2/src/kudu/master/master_path_handlers.cc@331
PS2, Line 331: (*output)["column_count"] = static_cast<int64_t>(schema.num_columns());
I suppose we ought to put a note here about why we're doing this random cast.
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 20:54:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master path handlers] fix build on macOS
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13274 )
Change subject: [master_path_handlers] fix build on macOS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 07 May 2019 20:53:38 +0000
Gerrit-HasComments: No
[kudu-CR] [master path handlers] fix build on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13274
to look at the new patch set (#2).
Change subject: [master_path_handlers] fix build on macOS
......................................................................
[master_path_handlers] fix build on macOS
This is a follow-up to fd6155fc00de48d17a65aafd79fbbad584a4f837.
After the patch mentioned above, but prior to this fix, an attempt to
build on macOS would fail with a linker error like below:
Undefined symbols for architecture x86_64:
"kudu::EasyJson& kudu::EasyJson::operator=<unsigned long>(unsigned long)", referenced from:
kudu::master::MasterPathHandlers::HandleTablePage(kudu::WebCallbackRegistry::WebRequest const&, kudu::WebCallbackRegistry::WebResponse*) in master_path_handlers.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
---
M src/kudu/master/master_path_handlers.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/13274/2
--
To view, visit http://gerrit.cloudera.org:8080/13274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36dda41528bbd427fd169e100c90a177cab85271
Gerrit-Change-Number: 13274
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>