[GitHub] [cloudstack] nvazquez commented on a change in pull request #5128: tests: Skip test_persistent_networks if kvm and ovs

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5128:
URL: https://github.com/apache/cloudstack/pull/5128#discussion_r659111764



##########
File path: test/integration/smoke/test_persistent_network.py
##########
@@ -52,6 +52,22 @@ def setUpClass(cls):
         cls.testClient = super(TestL2PersistentNetworks, cls).getClsTestClient()
         cls.api_client = cls.testClient.getApiClient()
         cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+        isKVM = cls.hypervisor.lower() in ["kvm"]
+        isOVSEnabled = False
+        hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
+        if isKVM :
+            # Test only if all the hosts use OVS
+            grepCmd = 'grep "network.bridge.type=openvswitch" /etc/cloudstack/agent/agent.properties'
+            hosts = list_hosts(cls.api_client, type='Routing', hypervisor='kvm')
+            if len(hosts) > 0 :
+                isOVSEnabled = True
+            for host in hosts :
+                isOVSEnabled = isOVSEnabled or len(SshClient(host.ipaddress, port=22, user=hostConfig["username"],

Review comment:
       If we want to ensure all hosts use OVS I think we need to add a check on the for loop and exit if `!isOVSEnabled`. Otherwise, we will only decide based on last host in the iteration




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org