You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/12/29 13:31:06 UTC
[GitHub] [httpcomponents-core] ok2c opened a new pull request #177:
HTTPCORE-617: removed references to specific RFC documents
ok2c opened a new pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on issue #177: HTTPCORE-617:
removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
ok2c commented on issue #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#issuecomment-569521470
@michael-o Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #177: HTTPCORE-617:
removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on issue #177: HTTPCORE-617:
removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
ok2c commented on issue #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#issuecomment-569505879
@michael-o Please let me know if you have any objections.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull
request #177: HTTPCORE-617: removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#discussion_r361850625
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -95,78 +93,70 @@
int SC_IM_USED = 226;
// --- 3xx Redirection ---
- /** {@code 3xx Redirection} (HTTP/1.1 - RFC 2616) */
+ /** {@code 3xx Redirection} (HTTP/1.1 - RFC 7231) */
int SC_REDIRECTION = 300;
- /** {@code 300 Mutliple Choices} (HTTP/1.1 - RFC 2616) */
+ /** {@code 300 Mutliple Choices} (HTTP/1.1 - RFC 7231) */
int SC_MULTIPLE_CHOICES = 300;
- /** {@code 301 Moved Permanently} (HTTP/1.0 - RFC 1945) */
+ /** {@code 301 Moved Permanently} (HTTP/1.0 - RFC 7231) */
int SC_MOVED_PERMANENTLY = 301;
- /** {@code 302 Moved Temporarily} (Sometimes {@code Found}) (HTTP/1.0 - RFC 1945) */
+ /** {@code 302 Moved Temporarily} (Sometimes {@code Found}) (HTTP/1.0 - RFC 7231) */
int SC_MOVED_TEMPORARILY = 302;
- /** {@code 303 See Other} (HTTP/1.1 - RFC 2616) */
+ /** {@code 303 See Other} (HTTP/1.1 - RFC 7231) */
int SC_SEE_OTHER = 303;
- /** {@code 304 Not Modified} (HTTP/1.0 - RFC 1945) */
+ /** {@code 304 Not Modified} (HTTP/1.0 - RFC 7231) */
int SC_NOT_MODIFIED = 304;
- /** {@code 305 Use Proxy} (HTTP/1.1 - RFC 2616) */
+ /** {@code 305 Use Proxy} (HTTP/1.1 - RFC 7231) */
int SC_USE_PROXY = 305;
- /** {@code 307 Temporary Redirect} (HTTP/1.1 - RFC 2616) */
+ /** {@code 307 Temporary Redirect} (HTTP/1.1 - RFC 7231) */
int SC_TEMPORARY_REDIRECT = 307;
/** {@code 308 Permanent Redirect} (HTTP/1.1 - RFC 7538) */
int SC_PERMANENT_REDIRECT = 308;
// --- 4xx Client Error ---
- /** {@code 4xx Client Error} (HTTP/1.1 - RFC 2616) */
+ /** {@code 4xx Client Error} (HTTP/1.1 - RFC 7231) */
int SC_CLIENT_ERROR = 400;
- /** {@code 400 Bad Request} (HTTP/1.1 - RFC 2616) */
+ /** {@code 400 Bad Request} (HTTP/1.1 - RFC 7231) */
int SC_BAD_REQUEST = 400;
- /** {@code 401 Unauthorized} (HTTP/1.0 - RFC 1945) */
+ /** {@code 401 Unauthorized} (HTTP/1.0 - RFC 7231) */
int SC_UNAUTHORIZED = 401;
- /** {@code 402 Payment Required} (HTTP/1.1 - RFC 2616) */
+ /** {@code 402 Payment Required} (HTTP/1.1 - RFC 7231) */
int SC_PAYMENT_REQUIRED = 402;
- /** {@code 403 Forbidden} (HTTP/1.0 - RFC 1945) */
+ /** {@code 403 Forbidden} (HTTP/1.0 - RFC 7231) */
int SC_FORBIDDEN = 403;
- /** {@code 404 Not Found} (HTTP/1.0 - RFC 1945) */
+ /** {@code 404 Not Found} (HTTP/1.0 - RFC 7231) */
int SC_NOT_FOUND = 404;
- /** {@code 405 Method Not Allowed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 405 Method Not Allowed} (HTTP/1.1 - RFC 7231) */
int SC_METHOD_NOT_ALLOWED = 405;
- /** {@code 406 Not Acceptable} (HTTP/1.1 - RFC 2616) */
+ /** {@code 406 Not Acceptable} (HTTP/1.1 - RFC 7231) */
int SC_NOT_ACCEPTABLE = 406;
- /** {@code 407 Proxy Authentication Required} (HTTP/1.1 - RFC 2616)*/
+ /** {@code 407 Proxy Authentication Required} (HTTP/1.1 - RFC 7231)*/
int SC_PROXY_AUTHENTICATION_REQUIRED = 407;
- /** {@code 408 Request Timeout} (HTTP/1.1 - RFC 2616) */
+ /** {@code 408 Request Timeout} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_TIMEOUT = 408;
- /** {@code 409 Conflict} (HTTP/1.1 - RFC 2616) */
+ /** {@code 409 Conflict} (HTTP/1.1 - RFC 7231) */
int SC_CONFLICT = 409;
- /** {@code 410 Gone} (HTTP/1.1 - RFC 2616) */
+ /** {@code 410 Gone} (HTTP/1.1 - RFC 7231) */
int SC_GONE = 410;
- /** {@code 411 Length Required} (HTTP/1.1 - RFC 2616) */
+ /** {@code 411 Length Required} (HTTP/1.1 - RFC 7231) */
int SC_LENGTH_REQUIRED = 411;
- /** {@code 412 Precondition Failed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 412 Precondition Failed} (HTTP/1.1 - RFC 7231) */
int SC_PRECONDITION_FAILED = 412;
- /** {@code 413 Request Entity Too Large} (HTTP/1.1 - RFC 2616) */
+ /** {@code 413 Request Entity Too Large} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_TOO_LONG = 413;
- /** {@code 414 Request-URI Too Long} (HTTP/1.1 - RFC 2616) */
+ /** {@code 414 Request-URI Too Long} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_URI_TOO_LONG = 414;
- /** {@code 415 Unsupported Media Type} (HTTP/1.1 - RFC 2616) */
+ /** {@code 415 Unsupported Media Type} (HTTP/1.1 - RFC 7231) */
int SC_UNSUPPORTED_MEDIA_TYPE = 415;
- /** {@code 416 Requested Range Not Satisfiable} (HTTP/1.1 - RFC 2616) */
+ /** {@code 416 Requested Range Not Satisfiable} (HTTP/1.1 - RFC 7231) */
int SC_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
- /** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 7231) */
int SC_EXPECTATION_FAILED = 417;
/** {@code 421 Misdirected Request} (HTTP/2 - RFC 7540) */
int SC_MISDIRECTED_REQUEST = 421;
- /**
- * Static constant for a 418 error.
- * {@code 418 Unprocessable Entity} (WebDAV drafts?)
- * or {@code 418 Reauthentication Required} (HTTP/1.1 drafts?)
- */
- // not used
- // int SC_UNPROCESSABLE_ENTITY = 418;
Review comment:
Since you have removed that, I do not see https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422 anywhere. This can be added in a subsequent commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on a change in pull
request #177: HTTPCORE-617: removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#discussion_r361850936
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -49,35 +47,35 @@
public interface HttpStatus {
Review comment:
We should NOT be using an interface to define constants, this should be a class. That's a class Effective Java item ;-) If this PR gets merged without that change. I can provide a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull
request #177: HTTPCORE-617: removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#discussion_r361850998
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -49,35 +47,35 @@
public interface HttpStatus {
Review comment:
I love Joshua Bloch! @garydgregory Let's move this to a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on a change in pull
request #177: HTTPCORE-617: removed references to specific RFC documents
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #177: HTTPCORE-617: removed references to specific RFC documents
URL: https://github.com/apache/httpcomponents-core/pull/177#discussion_r361850625
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpStatus.java
##########
@@ -95,78 +93,70 @@
int SC_IM_USED = 226;
// --- 3xx Redirection ---
- /** {@code 3xx Redirection} (HTTP/1.1 - RFC 2616) */
+ /** {@code 3xx Redirection} (HTTP/1.1 - RFC 7231) */
int SC_REDIRECTION = 300;
- /** {@code 300 Mutliple Choices} (HTTP/1.1 - RFC 2616) */
+ /** {@code 300 Mutliple Choices} (HTTP/1.1 - RFC 7231) */
int SC_MULTIPLE_CHOICES = 300;
- /** {@code 301 Moved Permanently} (HTTP/1.0 - RFC 1945) */
+ /** {@code 301 Moved Permanently} (HTTP/1.0 - RFC 7231) */
int SC_MOVED_PERMANENTLY = 301;
- /** {@code 302 Moved Temporarily} (Sometimes {@code Found}) (HTTP/1.0 - RFC 1945) */
+ /** {@code 302 Moved Temporarily} (Sometimes {@code Found}) (HTTP/1.0 - RFC 7231) */
int SC_MOVED_TEMPORARILY = 302;
- /** {@code 303 See Other} (HTTP/1.1 - RFC 2616) */
+ /** {@code 303 See Other} (HTTP/1.1 - RFC 7231) */
int SC_SEE_OTHER = 303;
- /** {@code 304 Not Modified} (HTTP/1.0 - RFC 1945) */
+ /** {@code 304 Not Modified} (HTTP/1.0 - RFC 7231) */
int SC_NOT_MODIFIED = 304;
- /** {@code 305 Use Proxy} (HTTP/1.1 - RFC 2616) */
+ /** {@code 305 Use Proxy} (HTTP/1.1 - RFC 7231) */
int SC_USE_PROXY = 305;
- /** {@code 307 Temporary Redirect} (HTTP/1.1 - RFC 2616) */
+ /** {@code 307 Temporary Redirect} (HTTP/1.1 - RFC 7231) */
int SC_TEMPORARY_REDIRECT = 307;
/** {@code 308 Permanent Redirect} (HTTP/1.1 - RFC 7538) */
int SC_PERMANENT_REDIRECT = 308;
// --- 4xx Client Error ---
- /** {@code 4xx Client Error} (HTTP/1.1 - RFC 2616) */
+ /** {@code 4xx Client Error} (HTTP/1.1 - RFC 7231) */
int SC_CLIENT_ERROR = 400;
- /** {@code 400 Bad Request} (HTTP/1.1 - RFC 2616) */
+ /** {@code 400 Bad Request} (HTTP/1.1 - RFC 7231) */
int SC_BAD_REQUEST = 400;
- /** {@code 401 Unauthorized} (HTTP/1.0 - RFC 1945) */
+ /** {@code 401 Unauthorized} (HTTP/1.0 - RFC 7231) */
int SC_UNAUTHORIZED = 401;
- /** {@code 402 Payment Required} (HTTP/1.1 - RFC 2616) */
+ /** {@code 402 Payment Required} (HTTP/1.1 - RFC 7231) */
int SC_PAYMENT_REQUIRED = 402;
- /** {@code 403 Forbidden} (HTTP/1.0 - RFC 1945) */
+ /** {@code 403 Forbidden} (HTTP/1.0 - RFC 7231) */
int SC_FORBIDDEN = 403;
- /** {@code 404 Not Found} (HTTP/1.0 - RFC 1945) */
+ /** {@code 404 Not Found} (HTTP/1.0 - RFC 7231) */
int SC_NOT_FOUND = 404;
- /** {@code 405 Method Not Allowed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 405 Method Not Allowed} (HTTP/1.1 - RFC 7231) */
int SC_METHOD_NOT_ALLOWED = 405;
- /** {@code 406 Not Acceptable} (HTTP/1.1 - RFC 2616) */
+ /** {@code 406 Not Acceptable} (HTTP/1.1 - RFC 7231) */
int SC_NOT_ACCEPTABLE = 406;
- /** {@code 407 Proxy Authentication Required} (HTTP/1.1 - RFC 2616)*/
+ /** {@code 407 Proxy Authentication Required} (HTTP/1.1 - RFC 7231)*/
int SC_PROXY_AUTHENTICATION_REQUIRED = 407;
- /** {@code 408 Request Timeout} (HTTP/1.1 - RFC 2616) */
+ /** {@code 408 Request Timeout} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_TIMEOUT = 408;
- /** {@code 409 Conflict} (HTTP/1.1 - RFC 2616) */
+ /** {@code 409 Conflict} (HTTP/1.1 - RFC 7231) */
int SC_CONFLICT = 409;
- /** {@code 410 Gone} (HTTP/1.1 - RFC 2616) */
+ /** {@code 410 Gone} (HTTP/1.1 - RFC 7231) */
int SC_GONE = 410;
- /** {@code 411 Length Required} (HTTP/1.1 - RFC 2616) */
+ /** {@code 411 Length Required} (HTTP/1.1 - RFC 7231) */
int SC_LENGTH_REQUIRED = 411;
- /** {@code 412 Precondition Failed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 412 Precondition Failed} (HTTP/1.1 - RFC 7231) */
int SC_PRECONDITION_FAILED = 412;
- /** {@code 413 Request Entity Too Large} (HTTP/1.1 - RFC 2616) */
+ /** {@code 413 Request Entity Too Large} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_TOO_LONG = 413;
- /** {@code 414 Request-URI Too Long} (HTTP/1.1 - RFC 2616) */
+ /** {@code 414 Request-URI Too Long} (HTTP/1.1 - RFC 7231) */
int SC_REQUEST_URI_TOO_LONG = 414;
- /** {@code 415 Unsupported Media Type} (HTTP/1.1 - RFC 2616) */
+ /** {@code 415 Unsupported Media Type} (HTTP/1.1 - RFC 7231) */
int SC_UNSUPPORTED_MEDIA_TYPE = 415;
- /** {@code 416 Requested Range Not Satisfiable} (HTTP/1.1 - RFC 2616) */
+ /** {@code 416 Requested Range Not Satisfiable} (HTTP/1.1 - RFC 7231) */
int SC_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
- /** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 2616) */
+ /** {@code 417 Expectation Failed} (HTTP/1.1 - RFC 7231) */
int SC_EXPECTATION_FAILED = 417;
/** {@code 421 Misdirected Request} (HTTP/2 - RFC 7540) */
int SC_MISDIRECTED_REQUEST = 421;
- /**
- * Static constant for a 418 error.
- * {@code 418 Unprocessable Entity} (WebDAV drafts?)
- * or {@code 418 Reauthentication Required} (HTTP/1.1 drafts?)
- */
- // not used
- // int SC_UNPROCESSABLE_ENTITY = 418;
Review comment:
Since you have removed that, I do not see https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/422 anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org