You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 16:50:15 UTC

[GitHub] [spark] warrenzhu25 commented on a change in pull request #29247: [SPARK-32446][SHS] Add percentile distribution REST API of peak memory metrics for all executors

warrenzhu25 commented on a change in pull request #29247:
URL: https://github.com/apache/spark/pull/29247#discussion_r523075442



##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -366,6 +366,18 @@ private[spark] class AppStatusStore(
     Some(computedQuantiles)
   }
 
+  /**
+   * Calculates a summary of the executor metrics for executors, returning the
+   * requested quantiles for the recorded metrics.
+   */
+  def executorMetricSummary(activeOnly: Boolean,
+                            unsortedQuantiles: Array[Double])

Review comment:
       Thanks for review. Updated all based on your comments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org