You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/13 07:55:15 UTC

[GitHub] [pulsar] nodece commented on a diff in pull request #15572: [cleanup][managed-ledger] Use TestNG instead of JUnit

nodece commented on code in PR #15572:
URL: https://github.com/apache/pulsar/pull/15572#discussion_r872103990


##########
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorInfoMetadataTest.java:
##########
@@ -73,8 +72,8 @@ public void testEncodeAndDecode(String compressionType) throws IOException {
             IllegalArgumentException compressionTypeEx = expectThrows(IllegalArgumentException.class, () -> {
                 new MetaStoreImpl(null, null, null, compressionType);
             });
-            assertEquals("No enum constant org.apache.bookkeeper.mledger.proto.MLDataFormats.CompressionType."
-                    + compressionType, compressionTypeEx.getMessage());
+            assertEquals(compressionType, compressionTypeEx.getMessage(),

Review Comment:
   Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org